Task #84376

Drop $GLOBALS['SOBE'] in NewRecordController

Added by Mathias Brodala about 2 years ago. Updated about 1 month ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2018-03-16
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The NewRecordController currently sets $GLOBALS['SOBE'] which is required by NewRecordPageTreeView::expandNext() to determine which page subtree to expand in the page creation wizard accessible through the page tree context menu.

This should be refactored to get rid of $GLOBALS['SOBE'] in this class.

Associated revisions

Revision 09fe017f (diff)
Added by Benni Mack 3 months ago

[BUGFIX] Hand over current page in NewRecordPageTreeView

Instead of using $GLOBALS['SOBE'] for this single usage, the constructor
is modified when building the Position Tree now.

Resolves: #84376
Releases: master
Change-Id: I49f340e431656f76f6be3d8027cf6640c38f6ad3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63625
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Daniel Goerz <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Daniel Goerz <>

History

#1 Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56254

#2 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56254

#3 Updated by Andreas Fernandez 10 months ago

  • Status changed from Under Review to New

#4 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63625

#5 Updated by Benni Mack 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF