Feature #84523: Allow preload Tag in Videorenderer - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Feature #84523

closed

Allow preload Tag in Videorenderer

Added by Michi Spandl over 6 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Michi Spandl

Category:

Fluid

Target version:

8.7.19

Start date:

2018-03-23

Due date:

% Done:

100%

Estimated time:

PHP Version:

Tags:

video, videorenderer, preload

Complexity:

easy

Sprint Focus:

On Location Sprint

Description

Hi,

it would be nice if I could use the preload (values: auto, none, preload) attribute on the <f:media Viewhelper within the additionalConfig attribute.
It only would be neccessariy to pass it through. In TYPO3\CMS\Core\Resource\Rendering\VideoTagRenderer on Line 97, add preload in foreach:

foreach (['class', 'dir', 'id', 'lang', 'style', 'title', 'accesskey', 'tabindex', 'onclick', 'controlsList','preload'] as $key) {
     if (!empty($options[$key])) {
          $attributes[] = $key . '="' . htmlspecialchars($options[$key]) . '"';
     }
}

Thanks, Michi

Actions

Copy link

Updated by Frans Saris over 6 years ago

Is this a official supported property?

Actions

Copy link

Updated by Michi Spandl over 6 years ago

It is: https://www.w3schools.com/tags/att_video_preload.asp

Frans Saris wrote:

Is this a official supported property?

Actions

Copy link

Updated by Frans Saris over 6 years ago

Okay, would be great if you could push a patch to our review system.

Actions

Copy link

Updated by Guido S. over 6 years ago

Related v9 feature: https://forge.typo3.org/issues/78264

I think this would be only a patch for v8, if we force the patch from 78264 :-)

Actions

Copy link

Updated by Benni Mack over 6 years ago

Target version changed from 8.7.13 to 8.7.19

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57274

Actions

Copy link

Updated by Guido Schmechel over 6 years ago

Because the patch 78264 will still take some time, I added the preload functionality individually. This as task and not as feature, due to the version setting of Benni.

Thanks to Michi for the code :-)

Actions

Copy link

Updated by Frans Saris over 6 years ago

Complexity changed from no-brainer to easy
Sprint Focus set to On Location Sprint

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57305

Actions

Copy link

#10