Feature #78264

Better support for html5 video/audio attributes

Added by Guido S. about 2 years ago. Updated 3 months ago.

Status:
Under Review
Priority:
Should have
Assignee:
Category:
Backend API
Start date:
2016-10-12
Due date:
% Done:

0%

PHP Version:
7.0
Tags:
Complexity:
easy
Sprint Focus:

Description

Hi,

we had some trouble with the videoplayer in 7.6. (Standard Media / HTML5) We can't use the "loop" attribute, because of there is no support in the backend.

On base of 8.4dev-master i wrote a little patch which could maybe used for a correct fix. (The patch fixes small typos in tests, too)

Additionally:
You decide that there is only one possibillity for a source tag in a video or an audio tag. Maybe this is incorrect, too? Or an political decision.

Best regards

video.patch View (18.2 KB) Guido S., 2016-10-12 14:36

video-v2.patch View (27.4 KB) Guido S., 2016-10-13 14:40

History

#1 Updated by Frans Saris about 2 years ago

  • Status changed from New to Needs Feedback

Hi,

We left out the loop, mute, controls, etc options as these are not all supported by the current 3 video integrations (YouTube, Vimeo and html5). Also it's rather easy to add these options by some additional TCA in a own extension.

The html embed version has only one source because you can only add 1 file so other sources aren't know in the renderer.

#2 Updated by Guido S. about 2 years ago

Hi Frans,

thanks for your feedback. But i think we should split the standard and the external videos. So i added a second patch which has two new "Filetypes" to split video, youtube and vimeo. With this requirement I can decide to create a different TCA for different cases. Example is given in this patch.

Maybe we can rethink the situation? ;-) (For more discussion you can reach me in slack @ayacoo)

#3 Updated by Frans Saris about 2 years ago

Hi Guido,

Creating a new file type for every possible video type will not work and isn't extendable by extensions.
These types are also similar with the types used by DAM systems etc.

What could be a solution is showing pallet elements by file extension. Maybe you could look into that.

Groet Frans

#4 Updated by Frans Saris about 2 years ago

Maybe you could also have a look at #77710 and the work of Sebastian https://github.com/smichaelsen/typo3-mediaoptions

This goes a little further than your suggestion but could maybe give you some ideas on how to proceed.

Here your find also another comment from my why we didn't implement all the features/options of these video integrations in the core https://forge.typo3.org/issues/77710#note-4

I don't want to say we will not add extra options to the core regarding the video options. But just want to point out what the original idea behind it was. Don't give the editor to much to choose by default :)

Options that IMO make sense:

- loop
- mute
- start point (https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Using_HTML5_audio_and_video#Specifying_playback_range)

But only if these are available for all core video renderers or can be hidden for the files that don't provide these options.

#5 Updated by Guido S. about 2 years ago

Thanks for your detailed feedback. I understand your intention, but... ;-)

My 2 Cents:
- Extend TCA is for developers and not for interators (See TCCI/TCCD exam ;-))
- If you don't give the full rights for fields you can exclude the fields in be groups. Admins should see all possible fields.

I left over the decision for you. If you are happy with this standard, you can close this ticket :-)

(BTw: We extend per TCA, too)

Best regards,
Guido

#6 Updated by Alexander Opitz almost 2 years ago

  • Tracker changed from Bug to Feature
  • Category set to Backend API
  • Status changed from Needs Feedback to New
  • Target version changed from 8 LTS to 9 LTS

Move this as feature to v9

#7 Updated by Guido S. 10 months ago

  • Assignee set to Guido S.

#8 Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55889

#9 Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55889

#10 Updated by Gerrit Code Review 10 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55889

#11 Updated by Gerrit Code Review 10 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55889

#12 Updated by Gerrit Code Review 10 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55889

#13 Updated by Gerrit Code Review 6 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55889

#14 Updated by Susanne Moog 3 months ago

  • Target version changed from 9 LTS to Candidate for Major Version

Also available in: Atom PDF