Project

General

Profile

Actions

Task #84567

closed

Update MediaViewHelper.php

Added by Forger Service about 6 years ago. Updated almost 5 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-03-30
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Allow additionalAttributes in function render
In some cases, it is useful to call the Render-Fuction with additionalAttributes from your fluid-Template (e.g. by providing a poster-Attribut with a video-Tag like <f:media additionalAttributes="{poster: 'fallback-img.jpg'}" )
Alltough this additionalAttributes ist already registered by the Core at this position, the function render() did not made use of it so far.
This issue was automatically created from https://github.com/TYPO3/TYPO3.CMS/pull/104

Actions #1

Updated by Gerrit Code Review about 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56490

Actions #2

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56490

Actions #3

Updated by Anja Leichsenring almost 6 years ago

  • Status changed from Under Review to Rejected

put additional attributes for the tag into additionalConfig parameter.

Actions #4

Updated by Stefan Froemken almost 5 years ago

Solved with TYPO3 9.0: https://forge.typo3.org/issues/81741

PS: As f:media renders videos as <iframe> it is not possible to change thumbnail with help of poster-Attribute. poster-Attribute is only allowed for <video>-Tag.
PPS: There is no need anymore to put additionalAttributes into additionalConfig.

Stefan

Actions

Also available in: Atom PDF