Bug #81741

MediaViewHelper does not pass additionalAttributes and data to renderer instance

Added by Dirk Döring 8 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Must have
Assignee:
-
Category:
Fluid
Start date:
2017-06-29
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
MediaViewHelper, viewHelper, video
Complexity:
easy
Is Regression:
Sprint Focus:
On Location Sprint

Description

<f:media additionalAttributes="{parameter:'argument'}" data="{src:'test'}"/>

results in HTML

<video controls><source src="source.mp4" type="video/mp4"></video>

should be

<video controls data-src="test" parameter="argument"><source src="source.mp4" type="video/mp4"></video>

Associated revisions

Revision 58919ba5 (diff)
Added by Markus Hölzle 6 months ago

[FEATURE] Render additionalAttributes and data-* attr in media renderer

Render additionalAttributes and data-* attributes in VideoTag,
YouTube, Vimeo and AudioRenderer if set in the Fluid MediaViewHelper.

Releases: master
Resolves: #81741
Change-Id: Ieef9eae905a33e09e225d3a563c3f31988a65a57
Reviewed-on: https://review.typo3.org/53488
Tested-by: TYPO3com <>
Reviewed-by: Joerg Boesche <>
Tested-by: Joerg Boesche <>
Reviewed-by: Frank Naegler <>
Reviewed-by: Sascha Rademacher <>
Tested-by: Sascha Rademacher <>
Reviewed-by: Henning Liebe <>
Tested-by: Henning Liebe <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

Revision 526f1795 (diff)
Added by Markus Sommer 18 days ago

[TASK] Reenable all additionals in video tag

Enable all additionalAttributes and additionalConfig’s to cover w3c and special spacs.

Resolves: #81743, #81741
Releases: master, 8.7
Change-Id: Ibfce2bd66e6de95eeb7c05eab160eec40ae437ef
Reviewed-on: https://review.typo3.org/53356
Tested-by: TYPO3com <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Susanne Moog 8 months ago

  • Sprint Focus set to On Location Sprint

#2 Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53488

#3 Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53488

#4 Updated by Gerrit Code Review 7 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53488

#5 Updated by Gerrit Code Review 7 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53488

#6 Updated by Gerrit Code Review 7 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53488

#7 Updated by Gerrit Code Review 7 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53488

#8 Updated by Gerrit Code Review 7 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53488

#9 Updated by Gerrit Code Review 6 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53488

#10 Updated by Gerrit Code Review 6 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53488

#11 Updated by Gerrit Code Review 6 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53488

#12 Updated by Markus Hölzle 6 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF