Project

General

Profile

Actions

Bug #84602

closed

Footer in single tt_content element

Added by Sven Burkert about 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend User Interface
Target version:
-
Start date:
2018-04-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
TCA, descriptionColumn, rowDescription
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

There is a little display issue in the footer of a content element, see appended file "beview.png": The framed area is the footer of that content element, but there shouldn't be a footer, not even an empty footer.

That's because of this code in function "tt_content_drawFooter" of class "PageLayoutView":

if (!empty($GLOBALS['TCA']['tt_content']['ctrl']['descriptionColumn'])) {
    $info[] = htmlspecialchars($row[$GLOBALS['TCA']['tt_content']['ctrl']['descriptionColumn']]);
}
$GLOBALS['TCA']['tt_content']['ctrl']['descriptionColumn'] is always set to "rowDescription", but $row['rowDescription'] is empty most times.

The resulting array $info is

array(1 item)
   0 => '' (0 chars)

but it should be an empty array.

Just write

if (!empty($GLOBALS['TCA']['tt_content']['ctrl']['descriptionColumn']) && $row[$GLOBALS['TCA']['tt_content']['ctrl']['descriptionColumn']]) { ...

and all should be fine.


Files

beview.png (7.22 KB) beview.png Sven Burkert, 2018-04-04 12:08

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #67603: Introduce TCA>descriptionColumn definitionClosed2015-06-18

Actions
Actions #1

Updated by Georg Ringer about 6 years ago

  • Assignee set to Georg Ringer
Actions #2

Updated by Georg Ringer about 6 years ago

  • Related to Feature #67603: Introduce TCA>descriptionColumn definition added
Actions #3

Updated by Gerrit Code Review about 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56550

Actions #4

Updated by Gerrit Code Review about 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56551

Actions #5

Updated by Georg Ringer about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF