Project

General

Profile

Actions

Bug #84635

closed

Folow-Up to https://review.typo3.org/#/c/55789/ - Unused code / ignored 8'typeicon_classes']['default'] and some other things

Added by Andreas Allacher over 6 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Start date:
2018-04-06
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

With the bugfix of #82850 and the https://review.typo3.org/#/c/55789/
if there is an issue with the record it now won't result in an exception.
However, the introduced code https://github.com/TYPO3/TYPO3.CMS/commit/aa4ce89d5263d5258ae8e35dc5daeb9eb9fae561#diff-8a7e6fca77c3b402775cb5b9ca9f5e99 sets

 $icon = $GLOBALS['TCA'][$table]['ctrl']['typeicon_classes']['default'];

which is completely ignored when retrieving the icon.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #82850: InputLinkElement fails with UnknownLinkHandlerExceptionClosedGeorg Ringer2017-10-24

Actions
Actions #1

Updated by Andreas Allacher over 6 years ago

Also I think the table name should be part of the explanation - if there is a table. Currently only the ID and the icon would be shown.
Of course, if the configuration is missing entirely and not just the record then this won't work but then the icon will not be available either, so in that case it might just be best to output the link identifier and the uid.

Actions #2

Updated by Andreas Allacher over 6 years ago

  • Subject changed from Folow-Up to https://review.typo3.org/#/c/55789/ - Unused code / ignored 8'typeicon_classes']['default'] to Folow-Up to https://review.typo3.org/#/c/55789/ - Unused code / ignored 8'typeicon_classes']['default'] and some other things
Actions #3

Updated by Riccardo De Contardi over 5 years ago

Does this issue still exists on 9.5.5 or later? The code reported on the description in the file typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php has been changed AFAICS

Actions #4

Updated by Benni Mack over 5 years ago

  • Target version changed from next-patchlevel to Candidate for patchlevel
Actions #5

Updated by Benni Mack almost 5 years ago

  • Related to Bug #82850: InputLinkElement fails with UnknownLinkHandlerException added
Actions #6

Updated by Benni Mack almost 5 years ago

  • Status changed from New to Closed

We're lacking feedback here, and apparantly it is fixed, so I will close this issue now.

Andreas, reach out to me if you still have this problem, so I can re-open the ticket.

Actions

Also available in: Atom PDF