Bug #84735

InlineControlContainer wrongly assumes group field values are still a string

Added by Franz Koch over 1 year ago. Updated 6 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
Start date:
2018-04-15
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The inlineControlContainer wrongly assumes that fields of type "group" still have the "_tablename|id|..." string as field value in "databaseRow", but this value is already converted into an array by the TcaGroup FromDataProvider.

See https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php#L198 for the according code in InlineControlContainer.

Affected versions are 8.7 and current master


Related issues

Related to TYPO3 Core - Bug #82104: IRRE + GROUP with real MM relations not working (fatal error) Closed 2017-08-15

Associated revisions

Revision db3a3ccc (diff)
Added by Cyril Janody about 1 year ago

[BUGFIX] Correct inline foreign_unique with target type="group" handling

Using type="inline" and MM relations having type="group" (instead of
type="select") and foreign_unique defined results in a fatal since
group db relations have been resolved to an array in TcaGroup data
provider already.

Change-Id: I20d138e7622aafb097a11e60014f9e4398bae811
Resolves: #82104
Resolves: #84735
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/58421
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Cyril Janody <>
Tested-by: Cyril Janody <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

Revision f4102ffe (diff)
Added by Cyril Janody about 1 year ago

[BUGFIX] Correct inline foreign_unique with target type="group" handling

Using type="inline" and MM relations having type="group" (instead of
type="select") and foreign_unique defined results in a fatal since
group db relations have been resolved to an array in TcaGroup data
provider already.

Change-Id: I20d138e7622aafb097a11e60014f9e4398bae811
Resolves: #82104
Resolves: #84735
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/58422
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56670

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56670

#3 Updated by Christian Kuhn about 1 year ago

  • Related to Bug #82104: IRRE + GROUP with real MM relations not working (fatal error) added

#4 Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58421

#5 Updated by Cyril Janody about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Gerrit Code Review about 1 year ago

  • Status changed from Resolved to Under Review

Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58422

#7 Updated by Cyril Janody about 1 year ago

  • Status changed from Under Review to Resolved

#8 Updated by Benni Mack 6 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF