Epic #84889

Epic #84280: Make unit tests notice free

Make frontend: PageRepository and PageRepositoryTest notice free

Added by Sybille Peters over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2018-04-28
Due date:
% Done:

100%

Sprint Focus:

Description

Core: Error handler (BE): PHP Notice: Undefined index: disabled in /var/www/linkvalidator/typo3/sysext/frontend/Classes/Page/PageRepository.php line 1364

Core: Error handler (BE): PHP Notice: Undefined index: starttime in /var/www/linkvalidator/typo3/sysext/frontend/Classes/Page/PageRepository.php line 1368

Core: Error handler (BE): PHP Notice: Undefined index: endtime in /var/www/linkvalidator/typo3/sysext/frontend/Classes/Page/PageRepository.php line 1372

Core: Error handler (BE): PHP Notice: Undefined index: TYPO3\CMS\Frontend\Page\PageRepository in /var/www/linkvalidator/typo3/sysext/frontend/Classes/Page/PageRepository.php line 209

Associated revisions

Revision 53cd95c8 (diff)
Added by Sybille Peters over 1 year ago

[TASK] Make PageRepositoryTest notice free

Resolves: #84889
Releases: master
Change-Id: Ied9640b8cf664086a5533b910e5ff2b1a2e6aece
Reviewed-on: https://review.typo3.org/56824
Tested-by: TYPO3com <>
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>
Reviewed-by: Fabien Udriot <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Andreas Wolf <>
Tested-by: Andreas Wolf <>

History

#1 Updated by Sybille Peters over 1 year ago

  • Subject changed from Make frontend: PageRepository notice free to Make frontend: PageRepository and PageRepositoryTest notice free

#2 Updated by Sybille Peters over 1 year ago

Not sure what to do about: the $_SERVER indexes in GeneralUtility::getIndpEnv line 2627

Shouldn't these get set with some sane values even if running from command line by bootstrap process?

PageRepositoryTest has tests that fail:

There was 1 error:

1) TYPO3\CMS\Frontend\Tests\Unit\Page\PageRepositoryTest::getExtUrlForDokType3PrependsSiteUrl
Undefined index: REMOTE_ADDR

/srv/tmp/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2631
/srv/tmp/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2789
/srv/tmp/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2792
/srv/tmp/cms/typo3/sysext/frontend/Tests/Unit/Page/PageRepositoryTest.php:79
/srv/tmp/cms/vendor/phpunit/phpunit/phpunit:53

There was 1 error:

1) TYPO3\CMS\Frontend\Tests\Unit\Page\PageRepositoryTest::getExtUrlForDokType3PrependsSiteUrl
Undefined index: ORIG_SCRIPT_NAME

/srv/tmp/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2629
/srv/tmp/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2789
/srv/tmp/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2792
/srv/tmp/cms/typo3/sysext/frontend/Tests/Unit/Page/PageRepositoryTest.php:79
/srv/tmp/cms/vendor/phpunit/phpunit/phpunit:53

ERRORS!

1) TYPO3\CMS\Frontend\Tests\Unit\Page\PageRepositoryTest::getExtUrlForDokType3PrependsSiteUrl
Undefined index: ORIG_SCRIPT_NAME

/srv/tmp/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2629
/srv/tmp/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2789
/srv/tmp/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2792
/srv/tmp/cms/typo3/sysext/frontend/Tests/Unit/Page/PageRepositoryTest.php:79
/srv/tmp/cms/vendor/phpunit/phpunit/phpunit:53

#3 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56824

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56824

#5 Updated by Sybille Peters over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF