Epic #84280

Make unit tests notice free

Added by Jan Helke over 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2018-03-15
Due date:
% Done:

100%

Sprint Focus:

Description

In order to archive a PHP E_NOTICE free core, we need to fix a lot of unit test.

Currently the notices were suppressed in the unit tests by

    /**
     * Subject is not notice free, disable E_NOTICES
     */
    protected static $suppressNotices = true;

After removing this code, the correspondend unit tests will fail if the cause an E_NOTICE.

Your mission, if you choose to accept it: Find the reasons for this notices and clean that up. Can be caused by the tests, by the test subjects or by dependencies.

Find yourself more issues by greping for the above string.


Subtasks

Task #84276: Make StringUtilityTest.php notice freeClosedAnja Leichsenring

Task #84277: Make ClassNamingUtilityTest.php notice freeClosedJan Helke

Task #84278: Make ExtensionUtilityTest.php notice freeClosedAnja Leichsenring

Task #84281: Make LocalizationUtilityTest.php notice freeClosedJan Helke

Task #84282: Make LocalizationFactoryTest.php notice freeClosedJan Helke

Task #84283: Make LocallangXmlParserTest.php notice freeClosedSascha Löffler

Bug #84301: Make AbstractNodeTest.php notice freeClosedJan Helke

Task #84302: Make DirectoryNodeTest notice freeClosedJan Helke

Task #84309: Make LogRecordTest notice freeClosed

Task #84310: Make SilentConfigurationUpgradeServiceTest notice freeClosedJan Helke

Task #84311: Make L10nModeUpdaterTest notice freeClosedJan Helke

Task #84312: Make AbstractCoreMatcherTest notice freeClosedJan Helke

Task #84313: Make ArrayDimensionMatcherTest notice freeClosedJan Helke

Task #84314: Make MethodArgumentDroppedMatcherTest notice freeClosedJan Helke

Task #84315: Make MethodArgumentDroppedStaticMatcherTest notice freeClosedJan Helke

Task #84316: Make MethodArgumentRequiredMatcherTest notice freeClosedJan Helke

Task #84317: Make MethodArgumentRequiredStaticMatcherTest notice freeClosedJan Helke

Task #84318: Make MethodArgumentUnusedMatcherTest notice freeClosedJan Helke

Task #84319: Make MethodCallMatcherTest notice freeClosedJan Helke

Task #84320: Make MethodCallStaticMatcherTest notice freeClosedJan Helke

Task #84325: Make AbstractWidgetViewHelperTest notice freeClosedJan Helke

Task #84328: Make LinkServiceTest.php notice freeClosedSascha Löffler

Task #84329: Make WidgetRequestBuilderTest notice freeClosedJan Helke

Task #84330: Make StandaloneViewTest notice freeClosedJan Helke

Task #84333: Make ProcessedFileTest.php notice freeClosedSascha Löffler

Task #84339: Make RedirectServiceTest.php notice freeClosedSascha Löffler

Task #84340: Make IfAuthenticatedViewHelperTest notice freeClosedJan Helke

Task #84345: Make CObjectViewHelperTest notice freeClosedJan Helke

Task #84346: Make FlashMessagesViewHelperTest notice freeClosedJan Helke

Task #84348: Make SelectViewHelperTest notice freeClosedJan Helke

Task #84350: Make FileSizeValidatorTest.php notice freeClosedSascha Löffler

Task #84351: Make FileLinkHandlerTest.php notice freeClosedSascha Löffler

Task #84355: Make ArrayUtilityTest.php notice freeClosedSascha Löffler

Task #84362: Make ServerRequestFactoryTest notice freeClosedSascha Löffler

Task #84366: Make CharsetConverterTest notice freeClosedSascha Löffler

Task #84371: Make WebProcessorTest notice freeClosedSascha Löffler

Task #84377: Make IconFactoryTest notice freeClosedSascha Löffler

Task #84378: Make PdoBackendTest notice freeClosedSascha Löffler

Task #84379: Make ExtensionStatusTest notice freeClosedJan Helke

Task #84380: Make ExtensionManagementServiceTest notice freeClosedJan Helke

Task #84381: Make EmConfUtilityTest notice freeClosedJan Helke

Task #84382: Make IconViewHelperTest notice freeClosedSascha Löffler

Task #84383: Make FileHandlingUtilityTest notice freeClosedJan Helke

Task #84384: Make InstallUtilityTest notice freeClosedJan Helke

Task #84385: Make ListUtilityTest notice freeClosedJan Helke

Task #84386: Make MailerTest notice freeClosedSascha Löffler

Task #84389: Make Typo3DatabaseBackendTest notice freeClosedSascha Löffler

Task #84390: Make FormEditorControllerTest notice freeClosedJan Helke

Task #84393: Make RteHtmlParserTest notice freeClosedSascha Löffler

Task #84394: Make FormManagerControllerTest notice freeClosedJan Helke

Task #84396: Make AbstractFinisher notice freeClosedJan Helke

Task #84397: Make form/Tests/Unit/Domain/FormElements/ notice freeClosedJan Helke

Task #84398: Make DataStructureIdentifierHookTest notice freeClosedJan Helke

Task #84401: Make sysext/form/Tests/Unit/Mvc/ notice freeClosedJan Helke

Task #84402: Make TranslationServiceTest notice freeClosedJan Helke

Task #84403: Make AbstractFileTest.php notice freeClosedŁukasz Uznański

Task #84405: Make FileTest.php notice freeClosedŁukasz Uznański

Task #84406: Make ResourceCompressorTest.php notice freeClosedŁukasz Uznański

Task #84413: Make sysext/backend/Tests/Unit/ notice freeClosedJan Helke

Task #84415: Make MimeTypeValidatorTest.php notice freeClosedŁukasz Uznański

Task #84417: Make AuthenticationServiceTest.php notice freeClosedŁukasz Uznański

Task #84418: Make LegacyLinkNotationConverterTest notice freeClosedŁukasz Uznański

Task #84421: Make AbstractFormProtectionTest notice freeClosedŁukasz Uznański

Task #84423: Make AbstractUserAuthenticationTest notice freeClosedSascha Löffler

Task #84424: Make BackendUtilityTest notice freeClosedJan Helke

Task #84425: Make BackendUserAuthenticationTest notice freeClosedŁukasz Uznański

Task #84426: Make TaskTest notice freeClosedSascha Löffler

Task #84427: Make AbstractConditionMatcherTest notice freeClosedŁukasz Uznański

Task #84428: Make FrontendWorkspaceRestrictionTest notice freeClosedSascha Löffler

Task #84429: Make FrontendUserAuthenticationTest notice freeClosedJan Helke

Task #84430: Make SessionTest notice freeClosedSascha Löffler

Task #84431: Make ConditionMatcherTest notive freeClosedJan Helke

Task #84432: Make ImageScriptServiceTest notice freeClosedŁukasz Uznański

Task #84433: Make VideoTagRendererTest notice freeClosedSascha Löffler

Task #84435: Make CommandLineBackendTest notice freeClosedSascha Löffler

Task #84436: Make AreaTest notice freeClosedŁukasz Uznański

Task #84437: Make DispatcherTest notice freeClosedSascha Löffler

Task #84438: Make FileWriterTest notice freeClosed

Task #84439: Make AudioTagRendererTest notice freeClosedSascha Löffler

Task #84440: Make SchemaColumnDefinitionListenerTest notice freeClosedŁukasz Uznański

Task #84441: Make VimeoRendererTest notice freeClosedSascha Löffler

Task #84442: Make BackendTest notice freeClosedSascha Löffler

Task #84444: Make TableBuilderTest notice freeClosedSascha Löffler

Task #84446: Make LogManagerTest notice freeClosedSascha Löffler

Task #84447: Make YouTubeRendererTest notice freeClosedSascha Löffler

Task #84451: Make ActionControllerTest notice freeClosedSascha Löffler

Task #84456: Make ContentObjectRendererTest notice freeClosedJan Helke

Task #85497: Code cleanup /frontend/Tests/Unit/ContentObject/ClosedJan Helke

Task #85601: Make ContentObjectRenderer notice free - part 1RejectedJan Helke

Task #84461: Make CacheHashCalculatorTest notice freeClosedSascha Löffler

Bug #84464: Wrong $host value when mailSettings['transport_smtp_server'] is not set.ClosedSascha Löffler

Task #84467: Make LocalDriverTest notice freeClosedŁukasz Uznański

Task #84468: Make UriBuilderTest notice freeClosedSascha Löffler

Task #84470: Make SqlReaderTest notice freeClosedSascha Löffler

Task #84720: Make FileBackendTest.php notice freeClosedJan Helke

Task #84721: Make CategoryRegistryTest.php notice freeClosedJan Helke

Task #84722: Make core/Tests/Unit/Configuration notice freeClosedJan Helke

Task #84723: Make core/Tests/Unit/Database/ notice freeClosedJan Helke

Task #84724: Make HtmlParserTest notice freeClosedJan Helke

Task #84808: Make core/Tests/Unit/Mail/ notice freeClosedJan Helke

Task #84816: Make core/Tests/Unit/Migrations/ notice freeClosedJan Helke

Task #84817: Make core/Tests/Unit/Package/ notice freeClosedJan Helke

Epic #84889: Make frontend: PageRepository and PageRepositoryTest notice freeClosedSybille Peters

Task #85088: Make Tests/Unit/Service/ notice freeClosedJan Helke

Task #85089: Make Tests/Unit/Tree/ notice freeClosedJan Helke

Task #85090: Make EnumerationTest.php notice freeClosedJan Helke

Task #85091: Make TypoScriptParserTest.php notice freeClosedJan Helke

Task #85092: Make Tests/Unit/TypoScript/ notice freeClosedJan Helke

Task #85093: Make RootlineUtilityTest.php notice freeClosedJan Helke

Task #85094: Make Tests/Unit/Configuration/ notice freeClosedJan Helke

Task #85095: Make NormalizeCommandTest.php notice freeClosedJan Helke

Task #85096: Make FileStreamWrapperTest.php notice freeRejectedJan Helke

Task #85097: Make core/Tests/UnitDeprecated/ notice freeClosedJan Helke

Task #85098: Make core/Tests/Unit/Resource/Driver/ notice freeClosedJan Helke

Task #85263: Make typo3/sysext/frontend/Tests/Unit/ContentObject notice freeClosedJan Helke

Task #85264: Make sysext/extbase/Tests/Unit notice freeClosedJan Helke

Task #85265: Make sysext/extbase/Tests/Unit/Mvc/Web/RequestBuilderTest.php notice freeClosedJan Helke

Task #85266: Make sysext/core/Tests/Unit/Resource notice freeRejectedJan Helke

Task #85267: Make extbase/Tests/Unit/Persistence/Generic/Mapper notice freeClosedJan Helke

Task #85268: Make sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php notice freeClosedJan Helke

Task #85269: Make sysext/extbase/Tests/Unit/Persistence/Generic/Storage/ notice freeClosedJan Helke

Task #85270: Make sysext/core/Tests/Unit/Resource/ notice freeClosedJan Helke

Task #85845: Make indexed search tests notice freeClosed

Task #85846: Make frontend/Classes/Typolink/ notice freeClosed

Task #85847: Make frontend/Tests/Unit/DataProcessing notice freeClosed

Task #85848: Make frontend/Tests/Unit/Plugin notice freeClosed

Task #85849: Make frontend/Tests/Unit/Page notice freeClosed

Task #85850: Make frontend/Tests/Unit/ContentObject/FilesContentObjectTest notice freeClosedWouter Wolters

Task #85851: Make frontend/Tests/Unit/Controller notice freeClosed

Task #85852: Make felogin/Test/Unit notice freeClosed

Task #85853: Make frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest notice freeClosed

Task #85854: Make AbstractMenuContentObjectTest notice freeClosed

Task #85855: Make ExtensionManagementUtilityTest notice freeClosed

Task #85861: Make core/Tests/Unit/Resource/ notice freeRejectedWouter Wolters

Task #85862: Make DataHandler notice freeClosedWouter Wolters

Task #85871: Make GeneralUtility tests notice freeClosed


Related issues

Related to TYPO3 Core - Task #83975: Notice free TcaSelectItems testing Closed 2018-02-20
Related to TYPO3 Core - Task #83888: Notice free unit tests Closed 2018-02-13
Related to TYPO3 Core - Bug #83981: Notice free FormEngine testing Closed 2018-02-20
Related to TYPO3 Core - Task #83908: Notice free InlineStackProcessor testing Closed 2018-02-15
Related to TYPO3 Core - Task #83889: Handle E_NOTICE free unit tests Closed 2018-02-13
Related to TYPO3 Core - Task #70584: Reduce thrown E_NOTICEs Closed 2018-03-07
Related to TYPO3 Core - Task #70590: Remove all notices thrown in BackendUtilityTest Closed 2015-10-11
Related to TYPO3 Core - Bug #71292: Reduce E_NOTICEs by providing correct test values and issets Closed 2015-11-03

Associated revisions

Revision 20b51f88 (diff)
Added by Christian Kuhn 11 months ago

[TASK] Raise typo3/testing-framework to 4.4.0

composer require --dev typo3/testing-framework:~4.4.0

With the removal of all '$suppressNotices = true' settings from
existing unit tests, this flag has now been removed from the
testing-framework. Core unit tests from now on must never trigger
notices, or fix the subject code along with new tests.

Resolves: #84280
Releases: master
Change-Id: Iffe6f6fa056a0203d2cb5474c25c36d2ef651578
Reviewed-on: https://review.typo3.org/57927
Tested-by: TYPO3com <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

History

#1 Updated by Jan Helke over 1 year ago

  • Description updated (diff)

#2 Updated by Christian Kuhn over 1 year ago

  • Related to Task #83975: Notice free TcaSelectItems testing added

#3 Updated by Christian Kuhn over 1 year ago

#4 Updated by Christian Kuhn over 1 year ago

  • Related to Bug #83981: Notice free FormEngine testing added

#5 Updated by Christian Kuhn over 1 year ago

  • Related to Task #83908: Notice free InlineStackProcessor testing added

#6 Updated by Christian Kuhn over 1 year ago

  • Related to Task #83889: Handle E_NOTICE free unit tests added

#7 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56158

#8 Updated by Christian Kuhn over 1 year ago

  • Related to Task #70584: Reduce thrown E_NOTICEs added

#9 Updated by Christian Kuhn over 1 year ago

  • Related to Task #70590: Remove all notices thrown in BackendUtilityTest added

#10 Updated by Christian Kuhn over 1 year ago

  • Related to Bug #71292: Reduce E_NOTICEs by providing correct test values and issets added

#11 Updated by Gerrit Code Review 11 months ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57927

#12 Updated by Gerrit Code Review 11 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57927

#13 Updated by Gerrit Code Review 11 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57927

#14 Updated by Christian Kuhn 11 months ago

  • Status changed from Under Review to Resolved

#15 Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF