Project

General

Profile

Actions
Copy link

Task #84933

closed

static variable in FileInfo

Added by Anja Leichsenring almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Anja Leichsenring
Category:
-
Target version:
-
Start date:
2018-05-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

there is a static variable hidden in FileInfo.php, which introduces issues for unittests. It can easily be replaced by a class variable.

Related issues 2 (0 open — 2 closed)

Related to TYPO3 Core - Task #84934: Add UnitTests for ImageInfoClosedAnja Leichsenring2018-05-06

Actions
Related to TYPO3 Core - Bug #66268: ImageInfo::getImageSizes() doesn't recognize all supported images formatsClosed2015-04-03

Actions
Actions
Copy link
 #1

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56867

Actions
Copy link
 #2

Updated by Anja Leichsenring almost 6 years ago

  • Related to Task #84934: Add UnitTests for ImageInfo added
Actions
Copy link
 #3

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56867

Actions
Copy link
 #4

Updated by Tymoteusz Motylewski almost 6 years ago

What issues?
Any idea why was it introduced as static variable in the first place?
I just want to avoid reintroducing some other issues with it.

Actions
Copy link
 #5

Updated by Anja Leichsenring almost 6 years ago

I had started with duplicating one test, that I wanted to adjust to another test case. The instance of GraphicalFunctions got in the way, because the test was not able to reset the mock.

I am not informed about the reason for putting a static variable there, it was introduced with #66268.

After conferring with Susi we decided it is bad design and agreed to replace it with a local class variable.

Actions
Copy link
 #6

Updated by Anja Leichsenring almost 6 years ago

  • Related to Bug #66268: ImageInfo::getImageSizes() doesn't recognize all supported images formats added
Actions
Copy link
 #7

Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56867

Actions
Copy link
 #8

Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56867

Actions
Copy link
 #9

Updated by Gerrit Code Review almost 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56867

Actions
Copy link
 #10

Updated by Gerrit Code Review almost 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56867

Actions
Copy link
 #11

Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56899

Actions
Copy link
 #12

Updated by Anonymous almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #13

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF