Bug #84987
closedAdd css style for broken page links in ckeditor
100%
Description
With the old rtehtmlarea broken links (at least page links which linked to not existing page) where displayed differently with a red border and yellow background. This is no longer working with ckeditor.
The broken links are apparently already marked with an additional attribute (see RteHtmlParser::markBrokenLinks):
<a data-rte-error= ...
If CSS for <a> elements with this attribute are added in the rte_ckeditor, the broken links could be visually displayed as broken links.
The style ('background-color: yellow; border:2px red solid; color: black;') that is added in RteHtmlParser::markBrokenLinks is probably removed by ckeditor.
Files
Updated by Gerrit Code Review over 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943
Updated by Sybille Peters over 6 years ago
- Related to Feature #84990: Check for other broken link types in RteHtmlParser added
Updated by Gerrit Code Review over 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943
Updated by Gerrit Code Review over 6 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943
Updated by Gerrit Code Review over 6 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943
Updated by Sybille Peters over 6 years ago
The patch needs more work, please also see https://typo3.slack.com/archives/C03AM9R17/p1526289651000331
Updated by Gerrit Code Review over 6 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943
Updated by Gerrit Code Review over 6 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943
Updated by Sybille Peters over 6 years ago
- Tracker changed from Feature to Bug
- TYPO3 Version set to 8
Updated by Gerrit Code Review over 6 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943
Updated by Sybille Peters over 6 years ago
- Related to Task #85007: Remove setting style for broken links in RteHtmlParser::markBrokenLinks added
Updated by Gerrit Code Review over 6 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56967
Updated by Gerrit Code Review over 6 years ago
Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56967
Updated by Sybille Peters over 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 83f4b861d8454b17446b41e82206162209a523d4.