Bug #84987

Add css style for broken page links in ckeditor

Added by Sybille Peters about 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
-
Start date:
2018-05-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

With the old rtehtmlarea broken links (at least page links which linked to not existing page) where displayed differently with a red border and yellow background. This is no longer working with ckeditor.

The broken links are apparently already marked with an additional attribute (see RteHtmlParser::markBrokenLinks):

<a data-rte-error= ...

If CSS for <a> elements with this attribute are added in the rte_ckeditor, the broken links could be visually displayed as broken links.

The style ('background-color: yellow; border:2px red solid; color: black;') that is added in RteHtmlParser::markBrokenLinks is probably removed by ckeditor.


Files

links.png (22 KB) links.png Sybille Peters, 2018-05-12 20:37

Related issues

Related to TYPO3 Core - Feature #84990: Check for other broken link types in RteHtmlParserClosedSybille Peters2018-05-12

Actions
Related to TYPO3 Core - Task #85007: Remove setting style for broken links in RteHtmlParser::markBrokenLinksClosedSybille Peters2018-05-15

Actions
#1

Updated by Gerrit Code Review about 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943

#2

Updated by Sybille Peters about 3 years ago

  • Related to Feature #84990: Check for other broken link types in RteHtmlParser added
#3

Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943

#4

Updated by Sybille Peters about 3 years ago

  • Description updated (diff)
#5

Updated by Gerrit Code Review about 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943

#6

Updated by Gerrit Code Review about 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943

#7

Updated by Sybille Peters about 3 years ago

  • Assignee set to Sybille Peters
#8

Updated by Sybille Peters about 3 years ago

The patch needs more work, please also see https://typo3.slack.com/archives/C03AM9R17/p1526289651000331

#9

Updated by Gerrit Code Review about 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943

#10

Updated by Sybille Peters about 3 years ago

  • Description updated (diff)
#11

Updated by Gerrit Code Review about 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943

#12

Updated by Sybille Peters about 3 years ago

  • Tracker changed from Feature to Bug
  • TYPO3 Version set to 8
#13

Updated by Sybille Peters about 3 years ago

  • Description updated (diff)
#14

Updated by Riccardo De Contardi about 3 years ago

  • Parent task set to #85006
#15

Updated by Gerrit Code Review about 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943

#16

Updated by Sybille Peters about 3 years ago

  • Related to Task #85007: Remove setting style for broken links in RteHtmlParser::markBrokenLinks added
#17

Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56967

#18

Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56967

#19

Updated by Sybille Peters about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#20

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed
#21

Updated by Sybille Peters over 1 year ago

  • Parent task deleted (#85006)

Also available in: Atom PDF