Bug #84987

Add css style for broken page links in ckeditor

Added by Sybille Peters over 1 year ago. Updated 6 days ago.

Status:
Closed
Priority:
Should have
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
-
Start date:
2018-05-12
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

With the old rtehtmlarea broken links (at least page links which linked to not existing page) where displayed differently with a red border and yellow background. This is no longer working with ckeditor.

The broken links are apparently already marked with an additional attribute (see RteHtmlParser::markBrokenLinks):

<a data-rte-error= ...

If CSS for <a> elements with this attribute are added in the rte_ckeditor, the broken links could be visually displayed as broken links.

The style ('background-color: yellow; border:2px red solid; color: black;') that is added in RteHtmlParser::markBrokenLinks is probably removed by ckeditor.

links.png View (22 KB) Sybille Peters, 2018-05-12 20:37


Related issues

Related to TYPO3 Core - Feature #84990: Check for other broken link types in RteHtmlParser Resolved 2018-05-12
Related to TYPO3 Core - Task #85007: Remove setting style for broken links in RteHtmlParser::markBrokenLinks Closed 2018-05-15

Associated revisions

Revision 83f4b861 (diff)
Added by Sybille Peters over 1 year ago

[BUGFIX] Add css for marking broken links in rte_ckeditor

The styling for broken page links that was added in
RteHtmlParser::markBrokenLinks is by default removed by ckeditor
so this functionality is no longer available by default.

Page links which link to a non-existing page currently already
get the additional attribute a[data-rte-error]. This patch adds
CSS to visually style broken links with a red border and yellow
background. This is the same styling that was previously used.

This is done by adding the plugin showbrokenlinks.

The style is still added in markBrokenLinks. These attributes
will be removed by ckeditor by default. However, the functionality
is kept to function as fallback.

Resolves: #84987
Releases: master, 8.7
Change-Id: I63e1e1db248fb2c343cdd19b41424621b684e87e
Reviewed-on: https://review.typo3.org/56943
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Sybille Peters <>
Tested-by: Sybille Peters <>
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Benjamin Kott <>
Tested-by: Benjamin Kott <>

Revision bdde39bc (diff)
Added by Sybille Peters over 1 year ago

[TASK] Remove setting style for broken links in RteHtmlParser

This is a followup for issue #84987. The style that is now set by
CSS file in rte_ckeditor should no longer be set by a PHP method.

Resolves: #85007
Related: #84987
Releases: master
Change-Id: Ie05ed7153802e6a655b3e6e473129a92db613714
Reviewed-on: https://review.typo3.org/56966
Tested-by: TYPO3com <>
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Benjamin Kott <>
Tested-by: Benjamin Kott <>

Revision 4a631a36 (diff)
Added by Sybille Peters over 1 year ago

[BUGFIX] Add css for marking broken links in rte_ckeditor

The styling for broken page links that was added in
RteHtmlParser::markBrokenLinks is by default removed by ckeditor
so this functionality is no longer available by default.

Page links which link to a non-existing page currently already
get the additional attribute a[data-rte-error]. This patch adds
CSS to visually style broken links with a red border and yellow
background. This is the same styling that was previously used.

This is done by adding the plugin showbrokenlinks.

The style is still added in markBrokenLinks. These attributes
will be removed by ckeditor by default. However, the functionality
is kept to function as fallback.

Resolves: #84987
Releases: master, 8.7
Change-Id: I63e1e1db248fb2c343cdd19b41424621b684e87e
Reviewed-on: https://review.typo3.org/56967
Tested-by: TYPO3com <>
Reviewed-by: Sybille Peters <>
Tested-by: Sybille Peters <>
Reviewed-by: Benjamin Kott <>
Tested-by: Benjamin Kott <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943

#2 Updated by Sybille Peters over 1 year ago

  • Related to Feature #84990: Check for other broken link types in RteHtmlParser added

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943

#4 Updated by Sybille Peters over 1 year ago

  • Description updated (diff)

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943

#7 Updated by Sybille Peters over 1 year ago

  • Assignee set to Sybille Peters

#8 Updated by Sybille Peters over 1 year ago

The patch needs more work, please also see https://typo3.slack.com/archives/C03AM9R17/p1526289651000331

#9 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943

#10 Updated by Sybille Peters over 1 year ago

  • Description updated (diff)

#11 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943

#12 Updated by Sybille Peters over 1 year ago

  • Tracker changed from Feature to Bug
  • TYPO3 Version set to 8

#13 Updated by Sybille Peters over 1 year ago

  • Description updated (diff)

#14 Updated by Riccardo De Contardi over 1 year ago

  • Parent task set to #85006

#15 Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56943

#16 Updated by Sybille Peters over 1 year ago

  • Related to Task #85007: Remove setting style for broken links in RteHtmlParser::markBrokenLinks added

#17 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56967

#18 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56967

#19 Updated by Sybille Peters over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#20 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

#21 Updated by Sybille Peters 6 days ago

  • Parent task deleted (#85006)

Also available in: Atom PDF