Project

General

Profile

Actions

Bug #85255

closed

Form Framework - "AdvancedPassword" throws exception

Added by Justus Moroni almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Form Framework
Start date:
2018-06-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.1
Tags:
Complexity:
easy
Is Regression:
Yes
Sprint Focus:

Description

In the TYPO3 Version 8.7.14 the following changes were added:
https://github.com/TYPO3/TYPO3.CMS/commit/70b8ffc06c68a21a5dc191d6b7f77b42092fc208

If someone switches to the new syntax of the partial "Field/Field". The AdvancedPassword form element is unusable.

In the TranslateElementErrorViewHelper the argument "error" was expected to be "TYPO3\CMS\Extbase\Validation\Error".
This works for every normal validator.

The AdvancedPassword form element is validated via a hook.
In this hook an error object "TYPO3\CMS\Extbase\Error\Error" was generated.

Therefore an exception was thrown that the type of the argument was not correct.


The fix is simple. The namespace for "Error" in "form/Classes/Hooks/FormElementsOnSubmitHooks.php" needs to be switched from "TYPO3\CMS\Extbase\Error\Error" to "TYPO3\CMS\Extbase\Validation\Error".

Actions #1

Updated by Justus Moroni almost 6 years ago

  • Target version changed from 8.7.19 to Candidate for patchlevel
Actions #2

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57210

Actions #3

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57210

Actions #4

Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57211

Actions #5

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57211

Actions #6

Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57212

Actions #7

Updated by Justus Moroni almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57212

Actions #9

Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57212

Actions #10

Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57212

Actions #11

Updated by Justus Moroni almost 6 years ago

  • Status changed from Under Review to Resolved
Actions #12

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF