Bug #85302

ResourceStorage throws wrong exception on folder move between storages

Added by Mathias Brodala almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Must have
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2018-06-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:
On Location Sprint

Description

The method ResourceStorage::moveFolderBetweenStorages() is currently not implemented and it throws a RuntimeException.

However, the ExtendedFileUtility::func_move() method implies that this should be a BadMethodCallException instead:

            catch (\BadMethodCallException $e) {
                $this->writeLog(3, 1, 126, 'The function to move a file between storages is not yet implemented', []);
                $this->addMessageToFlashMessageQueue('FileUtility.TheFunctionToMoveAFileBetweenStoragesIsNotYetImplemented');
            }

Due to this users get a misleading error messages which hints at write permission problems (FileUtility.DirectoryWasNotMovedTo) instead of the dedicated message which informs that this action is not yet implemented (FileUtility.TheFunctionToMoveAFileBetweenStoragesIsNotYetImplemented).


Related issues

Related to TYPO3 Core - Task #54230: Refactor Driver APIClosedSteffen Ritter2013-12-062013-12-31

Actions
#1

Updated by Mathias Brodala almost 3 years ago

#2

Updated by Mathias Brodala almost 3 years ago

  • Related to Task #54231: The Driver Registry should check for the implementation of the Interface added
#3

Updated by Mathias Brodala almost 3 years ago

  • Related to deleted (Task #54231: The Driver Registry should check for the implementation of the Interface)
#4

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57258

#5

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57258

#6

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57258

#7

Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57258

#8

Updated by Mathias Brodala almost 3 years ago

  • Sprint Focus set to On Location Sprint
#9

Updated by Gerrit Code Review almost 3 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57309

#10

Updated by Mathias Brodala almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#11

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF