Bug #85353: includeJSLibs gets overwritten by includeJSFooterlibs if same name is used - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #85353

closed

includeJSLibs gets overwritten by includeJSFooterlibs if same name is used

Added by Sebastian Klein almost 6 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

TypoScript

Target version:

next-patchlevel

Start date:

2018-06-22

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

7.2

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

There is no differentation between the two arrays includeJSLibs and includeJSFooterlibs if JavaScripts are included by using the same reference name.

If you include JavaScript files like this:

page {
    includeJSLibs {
        100 = EXT:your_ext/Resources/Public/JavaScript/javascript1.js
        javascript = EXT:your_ext/Resources/Public/JavaScript/javascript2.js
    }

    includeJSFooterlibs {
        100 = EXT:your_ext/Resources/Public/JavaScript/javascript3.js
        javascript = EXT:your_ext/Resources/Public/JavaScript/javascript4.js
    }
}

only the two JavaScripts from includeJSFooterlibs are rendered in the frontend.

I guess it's worth mentioning that this error was not reproducible with includeCSS and includeCSSLibs.

This issue was mentioned first in Slack by M. Stöckl (https://typo3.slack.com/archives/C025BQLFA/p1529333764000650) and referenced in https://forge.typo3.org/issues/85297?issue_count=66&issue_position=1&next_issue_id=85154#note-6

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Sebastian Klein almost 6 years ago

This issue seems to only apply to the mentioned TypoScript properties for JavaScript libraries. The properties includeJS and includeJSFooter are not affected by it.

Actions

Copy link

Updated by Georg Ringer almost 6 years ago

Related to Bug #85297: Breaking: TypoScript setup is overwritten added

Actions

Copy link

Updated by Guido Schmechel almost 6 years ago

Just a short notice for the patch:

The call runs via PageGenerator->renderContentWithHeader(). The file use $pageRenderer->addJsLibrary() and $pageRenderer->addJsFooterLibrary()

Both calls jump into their PageRenderer function and set the array $this->jsLibs. If the name is te same it will be overwritten.

PageRenderer::renderAdditionalJavaScriptLibraries should check the cariavle this->jsFooterLibs, too. In a first try i could render both files.

Actions

Copy link

Updated by Georg Ringer almost 6 years ago

Status changed from New to Accepted

Actions

Copy link

Updated by Gerrit Code Review almost 6 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57349

Actions

Copy link

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57349

Actions

Copy link

Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57360

Actions

Copy link