Project

General

Profile

Actions
Copy link

Task #85533

closed

LanguagePackCommand: Add option to not output the progress of the command

Added by Josef Glatz over 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
CLI
Target version:
-
Start date:
2018-07-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Problem/Description

It's annoying if the TYPO3 scheduler is running the update task language:update and does always output the progress like:

Updating language packs of all activated extensions for locales "bg, cs, fr, de, hu, it, pl, ru, sl" 
0/612 [>---------------------------] 0% 
1/612 [>---------------------------] 0% 
2/612 [>---------------------------] 0% 
3/612 [>---------------------------] 0% 
4/612 [>---------------------------] 0% 
5/612 [>---------------------------] 0% 
6/612 [>---------------------------] 0% 
7/612 [>---------------------------] 1% 
8/612 [>---------------------------] 1% 
9/612 [>---------------------------] 1% 
10/612 [>---------------------------] 1% 
11/612 [>---------------------------] 1% 
12/612 [>---------------------------] 1% 
13/612 [>---------------------------] 2% 
14/612 [>---------------------------] 2% 
15/612 [>---------------------------] 2% 
16/612 [>---------------------------] 2% 
17/612 [>---------------------------] 2% 
18/612 [>---------------------------] 2% 
19/612 [>---------------------------] 3% 
20/612 [>---------------------------] 3% 
21/612 [>---------------------------] 3% 
22/612 [=>--------------------------] 3% 
23/612 [=>--------------------------] 3% 
24/612 [=>--------------------------] 3% 
25/612 [=>--------------------------] 4% 
26/612 [=>--------------------------] 4% 
27/612 [=>--------------------------] 4% 
28/612 [=>--------------------------] 4% 
29/612 [=>--------------------------] 4% 
30/612 [=>--------------------------] 4% 
31/612 [=>--------------------------] 5% 
32/612 [=>--------------------------] 5% 
33/612 [=>--------------------------] 5% 
34/612 [=>--------------------------] 5% 
35/612 [=>--------------------------] 5% 
36/612 [=>--------------------------] 5% 
37/612 [=>--------------------------] 6% 
38/612 [=>--------------------------] 6% 
39/612 [=>--------------------------] 6% 
40/612 [=>--------------------------] 6% 
41/612 [=>--------------------------] 6% 
42/612 [=>--------------------------] 6% 
43/612 [=>--------------------------] 7% 
44/612 [==>-------------------------] 7% 
45/612 [==>-------------------------] 7% 
46/612 [==>-------------------------] 7% 
47/612 [==>-------------------------] 7% 
48/612 [==>-------------------------] 7% 
49/612 [==>-------------------------] 8% 
50/612 [==>-------------------------] 8% 
51/612 [==>-------------------------] 8% 
52/612 [==>-------------------------] 8% 
53/612 [==>-------------------------] 8% 
54/612 [==>-------------------------] 8% 
55/612 [==>-------------------------] 8% 
56/612 [==>-------------------------] 9% 
57/612 [==>-------------------------] 9% 
58/612 [==>-------------------------] 9% 
59/612 [==>-------------------------] 9% 
60/612 [==>-------------------------] 9% 
61/612 [==>-------------------------] 9% 
62/612 [==>-------------------------] 10% 
63/612 [==>-------------------------] 10% 
64/612 [==>-------------------------] 10% 
65/612 [==>-------------------------] 10% 
66/612 [===>------------------------] 10% 
67/612 [===>------------------------] 10% 
68/612 [===>------------------------] 11% 
69/612 [===>------------------------] 11% 
70/612 [===>------------------------] 11% 
71/612 [===>------------------------] 11% 
72/612 [===>------------------------] 11% 
73/612 [===>------------------------] 11% 
74/612 [===>------------------------] 12% 
75/612 [===>------------------------] 12% 
76/612 [===>------------------------] 12% 
77/612 [===>------------------------] 12% 
78/612 [===>------------------------] 12% 
79/612 [===>------------------------] 12% 
80/612 [===>------------------------] 13% 
...
...
...
...
...

This could lead to cronjob e-mails which doesn't contain errors and only the successfully completed language pack update.

ToDo(s)

  • add option to silent the progress
  • make it possible to set the option when the command is executed via scheduler
    • I would personally tend to disable the output by default and only show it if an option --show-progress.

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #91988: language:update command does not output anything when not called in verbose modeClosed2020-08-12

Actions
Actions
Copy link
 #1

Updated by Josef Glatz over 6 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57530

Actions
Copy link
 #3

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57530

Actions
Copy link
 #4

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57530

Actions
Copy link
 #5

Updated by Josef Glatz over 6 years ago

Update – After discussing the topic with Benni Mack and Mathias "wild" Brodala

The command should only output errors if no verbosity level is set.

  • Running ./bin/typo3 language:update -v should show the language pack update process progressBar
  • Running the above example without the -v option should NOT output anything
Actions
Copy link
 #6

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57530

Actions
Copy link
 #7

Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57530

Actions
Copy link
 #8

Updated by Gerrit Code Review over 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57530

Actions
Copy link
 #9

Updated by Gerrit Code Review over 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57530

Actions
Copy link
 #10

Updated by Gerrit Code Review over 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57530

Actions
Copy link
 #11

Updated by Gerrit Code Review over 6 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57530

Actions
Copy link
 #12

Updated by Anonymous over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #13

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link
 #14

Updated by Helmut Hummel over 4 years ago

Josef Glatz wrote:

  • add option to silent the progress

There is a generic option for that and this is -q or --quiet

Now only showing the progress when verbosity is set via -v is imho highly confusing for users just using the command from the command line
that are not aware that without verbosity set, the command basically acts like in --quiet mode

Actions
Copy link
 #15

Updated by Helmut Hummel over 4 years ago

  • Related to Bug #91988: language:update command does not output anything when not called in verbose mode added
Actions
Copy link

Also available in: Atom PDF