Task #85543

Introduce Language Aspect for Contexts

Added by Benni Mack 10 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
System/Bootstrap/Configuration
Target version:
Start date:
2018-07-12
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Bug #86223: Exception when using protectLvar=all in MenuProcessor Closed 2018-09-10
Related to TYPO3 Core - Bug #86285: TSFE properties are not fully deprecated Closed 2018-09-17

Associated revisions

Revision 4003c5fa (diff)
Added by Benni Mack 10 months ago

[TASK] Add LanguageAspect to Contexts

This change adds a new Aspect called "Language" which bundles
most existing TypoScript options on frontend language fetching.
A factory allows to migrate the logic from TSFE.

Major / Important Changes:
- RootlineUtility is decoupled from PageRepository
- TSFE->sys_language_mode is not necessary anymore
- TSFE->sys_language_contentOL can be substituted by "overlayType" of Aspect
- A new PageRepository->getLanguageOverlay() bundles all other methods
- A lot of common public properties in TSFE are now deprecated

Next steps:
- Isolate calls from RootlineUtility/PageRepository more from each other and from TSFE
- Migrate PageRepository "-1" parameters to "null"
- Migrate usages PageRepository->getRootline() to RootlineUtility::__construct()
- Then deprecate PageRepository->getRootLine()
- Migrate Extbase QuerySettings to Contexts

Resolves: #85543
Releases: master
Change-Id: I8d177222a244a8d1fd66a884e9fc50b107f27e20
Reviewed-on: https://review.typo3.org/57424
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

Revision 433418ba (diff)
Added by Benni Mack 7 months ago

[BUGFIX] Trigger deprecation when using $TSFE->sys_language_*

When deprecating TSFE->sys_language_mode and TSFE->sys_language_uid
it was forgotten (by myself) to set the visibility to protected.

This way, the deprecation layer (with compat calls) is never
used, and legacy code gets wrong results.

Resolves: #86285
Related: #85543
Releases: master
Change-Id: I2d809b577e5265054f2f54d54ecfbb8e441b6bdc
Reviewed-on: https://review.typo3.org/58303
Reviewed-by: Mathias Brodala <>
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision a553c62b (diff)
Added by Tymoteusz Motylewski 7 months ago

[BUGFIX] Pass language mode to QuerySettings in default language too

Introduction of the LanguageAspect changed the Extbase behavior, now it's
reintroduced.
When reviewing this patch please compare new code of
Typo3QuerySettings.php from this patch with state before
patch https://review.typo3.org/57424/ and compare
QueryLocalizedDataTest.php with one from v8 to see that
result is the same.

Resolves: #86332
Related: #85543
Releases: master
Change-Id: Ide9f5e1fe1875b942aac8d1187dc897cc1b20181
Reviewed-on: https://review.typo3.org/58351
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Tested-by: TYPO3com <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57424

#2 Updated by Gerrit Code Review 10 months ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57424

#3 Updated by Gerrit Code Review 10 months ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57424

#4 Updated by Gerrit Code Review 10 months ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57424

#5 Updated by Gerrit Code Review 10 months ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57424

#6 Updated by Gerrit Code Review 10 months ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57424

#7 Updated by Gerrit Code Review 10 months ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57424

#8 Updated by Gerrit Code Review 10 months ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57424

#9 Updated by Gerrit Code Review 10 months ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57424

#10 Updated by Gerrit Code Review 10 months ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57424

#11 Updated by Gerrit Code Review 10 months ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57424

#12 Updated by Gerrit Code Review 10 months ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57424

#13 Updated by Benni Mack 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#14 Updated by Georg Ringer 8 months ago

  • Related to Bug #86223: Exception when using protectLvar=all in MenuProcessor added

#15 Updated by Mathias Brodala 7 months ago

  • Related to Bug #86285: TSFE properties are not fully deprecated added

#16 Updated by Benni Mack 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF