Project

General

Profile

Actions

Feature #85739

closed

Reduce restrictions on database names introduced for DBAL

Added by J. Peter M. Schuler over 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Could have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2018-08-02
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Since #51093 there are restrictions on database schema names which can be entered during initial TYPO3 setup:

Given database name must be shorter than fifty characters and consist solely of 
* basic latin letters (a-z), 
* digits (0-9), 
* dollar signs ($) 
* and underscores (_).

These restrictions come from mySQL unquoted identifier rules (https://dev.mysql.com/doc/refman/5.7/en/identifiers.html). However all calls should be quoted anyways, so these restrictions could be dropped.

Background:

  1. From what I understood this was a move because of better DBAL support around the change from TYPO3 v6 to v7. Meanwhile Doctrine replaced the old DBAL approach.
  2. I don't get this decision in the first place, as in the moment the database is created the underlying used driver is known and might allow a less restrictive naming (or in theory be even more restrictive). Additionally this was introduced because of mySQL, not because of some other DB.
  3. I stumbled upon this in a new deployment, realising that we have had systems running TYPO3 v6, v7 and v8 which actually had database names not following this approach (having multiple dots in their name). These databases were renamed sometime during a migration to another server and the string was changed in LocalConfiguration.php directly, so we never stumbled upon this restriction change. Nevertheless all these systems ran fine.

So is there a need to have this kind of restrictive naming anymore? I couldn't find anything in the docs regarding this and the old reason seems to be outdated.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #96406: Do not create invalid sqlite db file namesClosedMarkus Klein2021-12-20

Actions
Has duplicate TYPO3 Core - Bug #90219: "Database name not valid" with sqlite and long path nameClosed2020-01-27

Actions
Actions #1

Updated by Gerrit Code Review almost 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63053

Actions #2

Updated by Gerrit Code Review almost 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63053

Actions #3

Updated by Gerrit Code Review almost 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63053

Actions #4

Updated by Gerrit Code Review almost 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63053

Actions #5

Updated by Gerrit Code Review almost 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63053

Actions #6

Updated by Gerrit Code Review almost 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63053

Actions #7

Updated by Gerrit Code Review almost 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63053

Actions #8

Updated by Daniel Siepmann almost 5 years ago

  • Has duplicate Bug #90219: "Database name not valid" with sqlite and long path name added
Actions #9

Updated by Gerrit Code Review almost 5 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63053

Actions #10

Updated by Gerrit Code Review almost 5 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63053

Actions #11

Updated by Gerrit Code Review over 4 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63053

Actions #12

Updated by Gerrit Code Review over 4 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63053

Actions #13

Updated by Manuel Selbach over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #14

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions #15

Updated by Markus Klein almost 3 years ago

  • Related to Bug #96406: Do not create invalid sqlite db file names added
Actions

Also available in: Atom PDF