Bug #85797

Bug #80875: Multiple problems with relation handler if too many records exist on a page

Too many record uids in plain data resolver break TYPO3

Added by Gleb Levitin about 1 year ago. Updated 6 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Database API (Doctrine DBAL)
Start date:
2018-08-09
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Do not use prepared statements in sorting function of plain data resolver.

Associated revisions

Revision f6e27a1c (diff)
Added by Gleb Levitin 8 months ago

[BUGFIX] Do not use named parameter for list of ids in plain data resolver

The plain data resolver sorts records by a list of uids.
This list can get very big so the database will fail if the
number of placesholders exceeds its limit.

Resolves: #85797
Releases: master, 9.5
Change-Id: I0b8a623fe00660b8f2c87a83a7e48ba430790d2b
Reviewed-on: https://review.typo3.org/c/57849
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Richard Haeser <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Benni Mack <>
Reviewed-by: Markus Klein <>
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Tested-by: Susanne Moog <>
Tested-by: Markus Klein <>

Revision bc767136 (diff)
Added by Gleb Levitin 8 months ago

[BUGFIX] Do not use named parameter for list of ids in plain data resolver

The plain data resolver sorts records by a list of uids.
This list can get very big so the database will fail if the
number of placesholders exceeds its limit.

Resolves: #85797
Releases: master, 9.5
Change-Id: I0b8a623fe00660b8f2c87a83a7e48ba430790d2b
Reviewed-on: https://review.typo3.org/c/59917
Tested-by: TYPO3com <>
Tested-by: Markus Klein <>
Reviewed-by: Markus Klein <>

History

#1 Updated by Gerrit Code Review about 1 year ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57849

#2 Updated by Gleb Levitin about 1 year ago

  • Assignee deleted (Gleb Levitin)

#3 Updated by Gleb Levitin about 1 year ago

  • Subject changed from Too many record uids in plain data resolver breaks TYPO3 to Too many record uids in plain data resolver break TYPO3

#4 Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57849

#5 Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57849

#6 Updated by Gleb Levitin about 1 year ago

  • Target version changed from next-patchlevel to 8.7.19

#7 Updated by Susanne Moog about 1 year ago

  • Target version changed from 8.7.19 to Candidate for patchlevel

#8 Updated by Gerrit Code Review 10 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57849

#9 Updated by Gerrit Code Review 9 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57849

#10 Updated by Gerrit Code Review 9 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57849

#11 Updated by Gerrit Code Review 8 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57849

#12 Updated by Anja Leichsenring 8 months ago

the method in question will be executed when the page tree is rebuild. So you can see it run into the parameter limit (theoretically) while refreshing the page tree frame.

the limit of parameters to be hit in order to get this function fail is
- on mysql and postgres > 30.000
- on sqlite 999

so in order to hit the limit for a test scenario the easiest way with the page tree, you need a page with 1000 direct active children and run your system on sqlite.

#13 Updated by Gerrit Code Review 8 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/57849

#14 Updated by Gerrit Code Review 8 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/57849

#15 Updated by Gerrit Code Review 8 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/57849

#16 Updated by Gerrit Code Review 8 months ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/57849

#17 Updated by Gerrit Code Review 8 months ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/57849

#18 Updated by Gerrit Code Review 8 months ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/57849

#19 Updated by Gerrit Code Review 8 months ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/57849

#20 Updated by Gerrit Code Review 8 months ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/57849

#21 Updated by Gerrit Code Review 8 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59917

#22 Updated by Gleb Levitin 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#23 Updated by Benni Mack 6 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF