Project

General

Profile

Actions
Copy link

Bug #85798

closed

Wrong mapping in domain model for table table sys_filemounts

Added by Ingo Reuter over 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2018-08-10
Due date:
% Done:

0%

Estimated time:
1.00 h
TYPO3 Version:
8
PHP Version:
Tags:
FAL, Extbase, Domain Model
Complexity:
easy
Is Regression:
Sprint Focus:

Description

The domain model of table sys_filemounts is not consistent to its table.

Particularly the database field 'base' is mapped to domain model property 'isAbsolutePath'. This is not the correct representation of the field's content.

The field 'base' stores the associated 'sys_file_storage' in which the filemount is defined. Hence the domain model should return an integer (or even better: fileStorage model) and not a value of type bool. Furthemore the domain model's property 'isAbsolutePath' should be renamed to something like 'base' or 'storage'.

The related files are (TYPO3 V8.7.18):
  • typo3/sysext/extbase/ext_typoscript_setup.typoscript (line: 20)
  • typo3/sysext/extbase/Classes/Domain/Model/FileMount.php (lines: 58 / 132-135 / 142-145)

Files

Download all files
ext_typoscript_setup.txt (3.08 KB) ext_typoscript_setup.txt Line 20 needs to be updated Ingo Reuter, 2018-08-10 01:04
FileMount.php (3.26 KB) FileMount.php isAbsolutePath needs to be changed Ingo Reuter, 2018-08-10 01:04
ext_typoscript_setup.patched.txt (3.07 KB) ext_typoscript_setup.patched.txt line 20 Ingo Reuter, 2018-08-10 01:26
FileMount.patched.php (3.04 KB) FileMount.patched.php lines 54 / 128-131 / 138 - 141 Ingo Reuter, 2018-08-10 01:26
Actions
Copy link
 #2

Updated by Ingo Reuter over 6 years ago

  • Category changed from Extbase to File Abstraction Layer (FAL)
  • Tags set to FAL, Extbase, Domain Model
Actions
Copy link
 #3

Updated by Susanne Moog over 5 years ago

Hey,

thanks for the report. Would you mind creating a patch on our review system? More info/how-to at https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Index.html

Actions
Copy link
 #4

Updated by Georg Ringer over 4 years ago

  • Status changed from New to Closed

Thanks for creating the issue. In fact with #90686 I would like to deprecate this model as there is absolutly no reason to have that as extbase model. If you really really need that in such way, please create an own model and register that.

Actions
Copy link

Also available in: Atom PDF