Task #86291

Improve the scheduler fluid template

Added by Josef Glatz about 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
scheduler
Target version:
-
Start date:
2018-09-18
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

What could be improved (context: fluid template listAction)?

The tables could look like the well known TYPO3 recordlist module

The look and feel of a collapsed scheduler task group table could also be improved

The TYPO3 administrator must get a "bigger" warning if at least one scheduler task class isn't available

A infobox can inform the admin even without scrolling down. A link within the infobox should directly link to the missingClasses anchor.

The instructions for missing class tasks could be improved

Add some info why something like this could happen and what you can do now


Scheduler_9-5-dev_improve-ui_001.png View (138 KB) Tobi Kretschmann, 2018-09-19 11:59

after-closed.png View - Patchset #11: A task group is closed (84.4 KB) Josef Glatz, 2018-09-20 07:19

after-opened.png View - Patchset #11: All task groups opened (113 KB) Josef Glatz, 2018-09-20 07:19

after-missingclass.png View - Patchset #11: The missing class table and the warning message (130 KB) Josef Glatz, 2018-09-20 07:19


Related issues

Related to TYPO3 Core - Bug #86358: Fix scheduler TaskList partial Closed 2018-09-23

Associated revisions

Revision 7db549d8 (diff)
Added by Josef Glatz about 1 year ago

[TASK] Improve the scheduler task group table listing

This patch basically adjusts the HTML markup for the listAction
to make the scheduler task tables look like the recordlist module.
Toggling of the tables was migrated to Bootstrap collapse which
is already in use inside the TYPO3 Install Tool.

Furthermore, an infobox will now be displayed if erroneous
scheduler tasks are found and the instructions are improved.

A scheduler task group is hidden from now on, if a task group
does not have any executable tasks at all (what will happen when
all scheduler tasks of a scheduler task group are shown in the
missingClasses scheduler task table).

Last but not least, automatic CGL were applied to the fluid
template. Incorrectly positioned CSS has been moved. Superfluous
CSS was removed.

Command `yarn build-css` was used to compile the CSS changes
for this patch.

Releases: master
Resolves: #86291
Change-Id: I4615841cd6e4db40b6633f47acfe625ea254ff10
Reviewed-on: https://review.typo3.org/58311
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>
Tested-by: TYPO3com <>
Reviewed-by: Benjamin Kott <>
Tested-by: Benjamin Kott <>

Revision 50a8923f (diff)
Added by Josef Glatz about 1 year ago

[BUGFIX] Fix scheduler TaskList partial

A translate VH was converted incorrectly in one of
the patchsets of #86291 before it was just merged
into the core.

Resolves: #86358
Related: #86291
Releases: master
Change-Id: Idead223d0a5ba988cb4d20e58d686c4e265b7eb1
Reviewed-on: https://review.typo3.org/58378
Tested-by: TYPO3com <>
Reviewed-by: Michael Oehlhof <>
Tested-by: Michael Oehlhof <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>

History

#1 Updated by Gerrit Code Review about 1 year ago

  • Status changed from In Progress to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

#2 Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

#3 Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

#4 Updated by Gerrit Code Review about 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

#5 Updated by Gerrit Code Review about 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

#6 Updated by Gerrit Code Review about 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

#7 Updated by Gerrit Code Review about 1 year ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

#8 Updated by Tobi Kretschmann about 1 year ago

  • File Scheduler_9-5-dev_improve-ui_001.png added

Not sure how picky I should be in this case but since it is called "improve UI" I thought I mention what I think could be improved :)

- The alignment is off between the different task groups. (@see screenshot)
- The whole task group header panel (.panel-heading.taskGroup) has "cursor: pointer" but no click action is defined.
- The info text in "Tasks without registered classes" have "cursor: pointer"

Other than that, I like the new segmentation of task groups and the display of missing classes. ;)

#9 Updated by Tobi Kretschmann about 1 year ago

  • File deleted (Scheduler_9-5-dev_improve-ui_001.png)

#11 Updated by Gerrit Code Review about 1 year ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

#12 Updated by Gerrit Code Review about 1 year ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

#13 Updated by Gerrit Code Review about 1 year ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

#14 Updated by Josef Glatz about 1 year ago

Tobi Kretschmann wrote:

Not sure how picky I should be in this case but since it is called "improve UI" I thought I mention what I think could be improved :)

- The alignment is off between the different task groups. (@see screenshot)
- The whole task group header panel (.panel-heading.taskGroup) has "cursor: pointer" but no click action is defined.
- The info text in "Tasks without registered classes" have "cursor: pointer"

Other than that, I like the new segmentation of task groups and the display of missing classes. ;)

Thanks Tobi for your input!

  • Alignment is something which must be fixed generally, as this is (AFAIK) like in the recordlist (list module) -> They are also not aligned. This is out of scope for this issue
  • The cursor: pointer thing was fixed! Thanks. In my fist try I tried to just use BS3 collapse feature. I had to add the taskGroup class while fixing the acceptance tests.
  • with my last patch, clicking the header of a task group is also possible (it triggers the BS3 collapse via js provided method) and also another js error (related to DataTables JS) was fixed by adopting HTML markup

#15 Updated by Josef Glatz about 1 year ago

Preview of Patchset #11 / #12

All task groups opened

#11: All task groups opened" alt="Patchset #11: All task groups opened" />

A task group is closed

#11: A task group is closed" alt="Patchset #11: A task group is closed" />

The missing class table and the warning message

#11: The missing class table and the warning message" alt="Patchset #11: The missing class table and the warning message" />

#16 Updated by Gerrit Code Review about 1 year ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

#17 Updated by Gerrit Code Review about 1 year ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

#18 Updated by Gerrit Code Review about 1 year ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

#19 Updated by Anonymous about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#20 Updated by Josef Glatz about 1 year ago

  • Related to Bug #86358: Fix scheduler TaskList partial added

#21 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF