Project

General

Profile

Actions

Task #86291

closed

Improve the scheduler fluid template

Added by Josef Glatz about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
scheduler
Target version:
-
Start date:
2018-09-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

What could be improved (context: fluid template listAction)?

The tables could look like the well known TYPO3 recordlist module

The look and feel of a collapsed scheduler task group table could also be improved

The TYPO3 administrator must get a "bigger" warning if at least one scheduler task class isn't available

A infobox can inform the admin even without scrolling down. A link within the infobox should directly link to the missingClasses anchor.

The instructions for missing class tasks could be improved

Add some info why something like this could happen and what you can do now



Files

Scheduler_9-5-dev_improve-ui_001.png (138 KB) Scheduler_9-5-dev_improve-ui_001.png Tobi Kretschmann, 2018-09-19 11:59
after-closed.png (84.4 KB) after-closed.png Patchset #11: A task group is closed Josef Glatz, 2018-09-20 07:19
after-opened.png (113 KB) after-opened.png Patchset #11: All task groups opened Josef Glatz, 2018-09-20 07:19
after-missingclass.png (130 KB) after-missingclass.png Patchset #11: The missing class table and the warning message Josef Glatz, 2018-09-20 07:19

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #86358: Fix scheduler TaskList partialClosedJosef Glatz2018-09-23

Actions
Actions #1

Updated by Gerrit Code Review about 6 years ago

  • Status changed from In Progress to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

Actions #2

Updated by Gerrit Code Review about 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

Actions #3

Updated by Gerrit Code Review about 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

Actions #4

Updated by Gerrit Code Review about 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

Actions #5

Updated by Gerrit Code Review about 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

Actions #6

Updated by Gerrit Code Review about 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

Actions #7

Updated by Gerrit Code Review about 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

Actions #8

Updated by Tobi Kretschmann about 6 years ago

  • File Scheduler_9-5-dev_improve-ui_001.png added

Not sure how picky I should be in this case but since it is called "improve UI" I thought I mention what I think could be improved :)

- The alignment is off between the different task groups. (@see screenshot)
- The whole task group header panel (.panel-heading.taskGroup) has "cursor: pointer" but no click action is defined.
- The info text in "Tasks without registered classes" have "cursor: pointer"

Other than that, I like the new segmentation of task groups and the display of missing classes. ;)

Actions #9

Updated by Tobi Kretschmann about 6 years ago

  • File deleted (Scheduler_9-5-dev_improve-ui_001.png)
Actions #11

Updated by Gerrit Code Review about 6 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

Actions #12

Updated by Gerrit Code Review about 6 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

Actions #13

Updated by Gerrit Code Review about 6 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

Actions #14

Updated by Josef Glatz about 6 years ago

Tobi Kretschmann wrote:

Not sure how picky I should be in this case but since it is called "improve UI" I thought I mention what I think could be improved :)

- The alignment is off between the different task groups. (@see screenshot)
- The whole task group header panel (.panel-heading.taskGroup) has "cursor: pointer" but no click action is defined.
- The info text in "Tasks without registered classes" have "cursor: pointer"

Other than that, I like the new segmentation of task groups and the display of missing classes. ;)

Thanks Tobi for your input!

  • Alignment is something which must be fixed generally, as this is (AFAIK) like in the recordlist (list module) -> They are also not aligned. This is out of scope for this issue
  • The cursor: pointer thing was fixed! Thanks. In my fist try I tried to just use BS3 collapse feature. I had to add the taskGroup class while fixing the acceptance tests.
  • with my last patch, clicking the header of a task group is also possible (it triggers the BS3 collapse via js provided method) and also another js error (related to DataTables JS) was fixed by adopting HTML markup

Updated by Josef Glatz about 6 years ago

Preview of Patchset #11 / #12

All task groups opened

Patchset #11: All task groups opened

A task group is closed

Patchset #11: A task group is closed

The missing class table and the warning message

Patchset #11: The missing class table and the warning message

Actions #16

Updated by Gerrit Code Review about 6 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

Actions #17

Updated by Gerrit Code Review about 6 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

Actions #18

Updated by Gerrit Code Review about 6 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58311

Actions #19

Updated by Anonymous about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #20

Updated by Josef Glatz about 6 years ago

  • Related to Bug #86358: Fix scheduler TaskList partial added
Actions #21

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF