Bug #86420
closed
Scheduler executes deleted tasks
100%
Description
Since #79777 tasks do not get removed from database, but marked as deleted.
But the function "fetchTask($uid = 0)" in the Scheduler class wasn't updated accordingly. This function builds an own SQL with QueryBuilder with "$queryBuilder->getRestrictions()->removeAll();" so we also fetch disabled tasks.
Updated by Jan Helke almost 6 years ago
- Status changed from New to Accepted
- Assignee set to Jan Helke
Updated by Jan Helke almost 6 years ago
How to test:
- Pick a random scheduler task. Or create a new Scheduler test task (scheduler) with a very low frequency
- run "./bin/typo3 scheduler:run - i <ID> --force"
- Check in the scheduler module that the task ran and make a note of the Last Execution time
- Delete the task
- Grab a coffee (it should take a minute or more to see the change in the Execution time)
- run "./bin/typo3 scheduler:run - i <ID> --force" again
- Go to the Database and restore the task
- Go to the scheduler module and see, that the Execution Time changed
Updated by Jan Helke almost 6 years ago
Other case:
- Pick a random scheduler task. Or create a new Scheduler test task (scheduler) with a very low frequency
- run "./bin/typo3 scheduler:run" (runs all tasks)
- Check in the scheduler module that the task ran and make a note of the Last Execution time
- Delete the task
- Grab a coffee (it should take a minute or more to see the change in the Execution time)
- run "./bin/typo3 scheduler:run" again
- Go to the Database and restore the task
- Go to the scheduler module and see, that the Execution Time changed
Updated by Gerrit Code Review almost 6 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58439
Updated by Jan Helke almost 6 years ago
Both issues should be fixed with this patch.
Updated by Gerrit Code Review almost 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58439
Updated by Gerrit Code Review almost 6 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58439
Updated by Gerrit Code Review almost 6 years ago
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58504
Updated by Gerrit Code Review almost 6 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58439
Updated by Benni Mack almost 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 797689b1323c4dd27150675652ac8b7730445884.
Updated by Benni Mack almost 6 years ago
- Status changed from Resolved to Closed