Project

General

Profile

Actions

Bug #86436

closed

Performance of extension scanner

Added by Frank Nägler over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Install Tool
Target version:
Start date:
2018-09-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
medium
Is Regression:
Sprint Focus:

Description

In some cases the extension scanner produce a lot of CPU usage which results in a browser crash.
I can reproduce this by scanning the extension: bootstrap_package
After scanning the ~100 files the browser freeze and the CPU usage is too high.

See the video attached

The problem is the second extension in the scanner list, it contains 4468 files, the scanner now create for all files in all extensions one AJAX call, in my case 4700 AJAX calls are send to the web-server.

This has several impacts:

1) browser freezes
2) web server get under massiv load
3) WAF or iptables will take care of the "attac"


Files

extension_scanner_bug.mov (4.75 MB) extension_scanner_bug.mov Frank Nägler, 2018-09-29 12:09

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #86523: Scanning an extension after first scan not possible anymoreClosedAndreas Kienast2018-10-01

Actions
Actions #2

Updated by Frank Nägler over 5 years ago

  • Description updated (diff)
Actions #3

Updated by Frank Nägler over 5 years ago

  • Description updated (diff)
  • Priority changed from Should have to Must have
  • Complexity set to medium
Actions #4

Updated by Frank Nägler over 5 years ago

  • Description updated (diff)
Actions #5

Updated by Frank Nägler over 5 years ago

  • Description updated (diff)
Actions #6

Updated by Frank Nägler over 5 years ago

I see the following possible solutions:

1) set async: false
2) Use a AJAX queue manager

both solutions are not optimal, because:
1) would be easy, but slow down the scanner
2) is a bigger refactoring, which is not possible so close before LTS release

I am not happy with this situation and have no idea how to solve or mitigate this bug.

Actions #7

Updated by Gerrit Code Review over 5 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58510

Actions #8

Updated by Frank Nägler over 5 years ago

  • Assignee set to Frank Nägler
Actions #9

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58510

Actions #10

Updated by Frank Nägler over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Andreas Kienast over 5 years ago

  • Related to Bug #86523: Scanning an extension after first scan not possible anymore added
Actions #12

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF