Task #86490

Update doctrine/dbal to 2.8.0

Added by Benni Mack 9 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Database API (Doctrine DBAL)
Start date:
2018-10-01
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Task #87679: Raise typo3/testing-framework from 5.0.4 to 5.0.5 Rejected 2019-02-08
Related to TYPO3 Core - Task #87681: Raise typo3/testing-framework from 4.11.2 to 4.11.3 Rejected 2019-02-08

Associated revisions

Revision c89da5f5 (diff)
Added by Benni Mack 4 months ago

[TASK] Update doctrine/dbal to ~2.8.0

doctrine/dbal 2.7.x will reach end of life before core
v9 is out of support. We should upgrade to at least 2.8:

composer req doctrine/dbal:~2.8.0

https://www.doctrine-project.org/2018/07/12/common-2-9-and-dbal-2-8-and-orm-2-6-2.html

Also needs a typo3/testing-framework raise:

composer req --dev typo3/testing-framework:~5.0.5

Needed core changes:
- DBAL does not add "OFFSET 0" if nothing given (test change only)
- SQLite does not need "PRIMARY KEY" if autoincrement is given (in DefaultTcaSchema)

Resolves: #86490
Releases: master, 9.5
Change-Id: I28014d252a57f7f421242e35086c63a0a824ed04
Reviewed-on: https://review.typo3.org/59668
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

Revision 9d5a6e3a (diff)
Added by Benni Mack 4 months ago

[TASK] Update doctrine/dbal to ~2.8.0

doctrine/dbal 2.7.x will reach end of life before core
v9 is out of support. We should upgrade to at least 2.8:

composer req doctrine/dbal:~2.8.0

https://www.doctrine-project.org/2018/07/12/common-2-9-and-dbal-2-8-and-orm-2-6-2.html

Also needs a typo3/testing-framework raise:

composer req --dev typo3/testing-framework:~4.11.3

Needed core changes:
- DBAL does not add "OFFSET 0" if nothing given (test change only)
- SQLite does not need "PRIMARY KEY" if autoincrement is given (in DefaultTcaSchema)

Resolves: #86490
Releases: master, 9.5
Change-Id: I28014d252a57f7f421242e35086c63a0a824ed04
Reviewed-on: https://review.typo3.org/59673
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58513

#2 Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58513

#3 Updated by Gerrit Code Review 9 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58513

#4 Updated by Benni Mack 9 months ago

  • Target version changed from 9 LTS to Candidate for patchlevel

#5 Updated by Christian Kuhn 9 months ago

  • Status changed from Under Review to New

#6 Updated by Gerrit Code Review 4 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59668

#7 Updated by Gerrit Code Review 4 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59668

#8 Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59668

#9 Updated by Gerrit Code Review 4 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59668

#10 Updated by Christian Kuhn 4 months ago

  • Related to Task #87679: Raise typo3/testing-framework from 5.0.4 to 5.0.5 added

#11 Updated by Christian Kuhn 4 months ago

  • Related to Task #87681: Raise typo3/testing-framework from 4.11.2 to 4.11.3 added

#12 Updated by Gerrit Code Review 4 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59668

#13 Updated by Gerrit Code Review 4 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59668

#14 Updated by Gerrit Code Review 4 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59668

#15 Updated by Gerrit Code Review 4 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59673

#16 Updated by Gerrit Code Review 4 months ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59673

#17 Updated by Gerrit Code Review 4 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59668

#18 Updated by Gerrit Code Review 4 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59668

#19 Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59673

#20 Updated by Benni Mack 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#21 Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF