Bug #86751
closedPressing "Mark undone" of "Migrate all file relations from fe_users.image to sys_file_references" has no effect
100%
Description
Because of a logical bug inside the "updateNecessary" method, the wizard doesn't come up after pressing the "Mark undone" button inside the upgrate wizard.
The problem is the init() call, which sets the property recordOffset to [] if there is no registry key recordOffset found.
This is alway the case, until there was an unfinised run before.
Anyway, to fix this problem the updateNecessary method should be changed to:
public function updateNecessary(): bool { $this->registry = GeneralUtility::makeInstance(Registry::class); return $this->registry->get($this->registryNamespace, 'recordOffset') === null; }
Additionaly the migration will fail, because of a not more existing "sorting" field inside the sys_file_references table.
To fix this, only this line (311) must be removed:
'sorting' => $i + 256,
A patch for both problems is attached.
Files
Updated by Gerrit Code Review about 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58795
Updated by Gerrit Code Review about 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58795
Updated by Alexander Grein about 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f7b5985f21e0fc81dbbde9fa07c782d12f2c3316.