Project

General

Profile

Actions

Bug #86751

closed

Pressing "Mark undone" of "Migrate all file relations from fe_users.image to sys_file_references" has no effect

Added by Alexander Grein about 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2018-10-26
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Because of a logical bug inside the "updateNecessary" method, the wizard doesn't come up after pressing the "Mark undone" button inside the upgrate wizard.

The problem is the init() call, which sets the property recordOffset to [] if there is no registry key recordOffset found.
This is alway the case, until there was an unfinised run before.

Anyway, to fix this problem the updateNecessary method should be changed to:

public function updateNecessary(): bool
    {
        $this->registry = GeneralUtility::makeInstance(Registry::class);
        return $this->registry->get($this->registryNamespace, 'recordOffset') === null;
    }

Additionaly the migration will fail, because of a not more existing "sorting" field inside the sys_file_references table.

To fix this, only this line (311) must be removed:

'sorting' => $i + 256,

A patch for both problems is attached.


Files

frontenduserimageupdatewizard.patch (1.01 KB) frontenduserimageupdatewizard.patch Alexander Grein, 2018-10-26 11:41
Actions

Also available in: Atom PDF