Project

General

Profile

Actions
Copy link

Bug #86947

closed

Gifbuilder: combine images generates duplicate images of the same picture.

Added by Arne Bracht about 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Image Generation / GIFBUILDER
Target version:
-
Start date:
2018-11-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.0
Tags:
Gifbuilder
Complexity:
Is Regression:
Sprint Focus:

Description

Since TYPO3 8.7.20 the Folder: typo3temp/assets/images/ growth extremly

I found that my gallery images are stored there, which are generated by the Gifbuilder.

Every time the frontend gallery is hit, a new image with watermark is generated:

csm_oehde9i_aaae4a5f3d_logo5_a77ed9c6fb.jpg
csm_oehde9i_aaae4a5f3d_logo5_f386a36af5.jpg
csm_oehde9i_aaae4a5f3d_logo5_71836c512b.jpg

The last digits change, filesize is the same and it's the same picture. So the images are not cached and the Folder growth unlimited.

TYPO3 8.7.19 is without this problem.

Thanks. Arne Bracht

lib.imageWithWatermark = COA
lib.imageWithWatermark {
  20 = IMAGE
  20 {
    file = GIFBUILDER
    file {
      XY = [10.w],[10.h]
      format = jpg
      quality = 100      

      10 = IMAGE
      10.file {
        import.data = current
        treatIdAsReference = 1
        width = 130c
        height = 100c
      }

      15 = IMAGE
      15.offset = [10.w]-29,[10.h]-40
      15.file = fileadmin/layout/images/logo5.png

    }
  }
}

Related issues 2 (0 open — 2 closed)

Related to TYPO3 Core - Bug #87224: GifBuilder creates filename hashes over and overClosed2018-12-19

Actions
Related to TYPO3 Core - Bug #44518: Caching problem with GifbuilderClosed2013-01-14

Actions
Actions
Copy link
 #1

Updated by Guido Schmechel about 6 years ago

Can reproduce it with the current master.

There are some differences in $this->setup which deliver a different md5 and so a different filename.

Actions
Copy link
 #2

Updated by Arne Bracht about 6 years ago

I think this change in typo3/sysext/core/Classes/Resource/ProcessedFile.php

identifier == null to identifier === null
Line 406 is responsible for this failure.

https://github.com/TYPO3/TYPO3.CMS/commit/9bb994f492e75efcfe139c3d6a64ef42dbef9bd1

    /**
      * @return bool
     */
    public function usesOriginalFile()
    {
 -       return $this->identifier == null || $this->identifier === $this->originalFile->getIdentifier();
 +       return $this->identifier === null || $this->identifier === $this->originalFile->getIdentifier();
    }
     /**
Actions
Copy link
 #3

Updated by Guido Schmechel about 6 years ago

We also had the guess. But the problem is probably even deeper.

I see in v 9.5 a changed "requestId". This is part of the Logger which is passed to a SignalSlot which is coming through the processing. Benni know about it and will check it. I spent two hours yesterday but could not find a really coherent position.

Actions
Copy link
 #4

Updated by Arne Bracht almost 6 years ago

Also, still exists in TYPO3 8.7.21

But i think i'm the last dinosaur who uses watermark images with pictures...

Actions
Copy link
 #5

Updated by Guido Schmechel almost 6 years ago

  • Related to Bug #87224: GifBuilder creates filename hashes over and over added
Actions
Copy link
 #6

Updated by Thomas Oliver Moll almost 6 years ago

  • Related to Bug #44518: Caching problem with Gifbuilder added
Actions
Copy link
 #7

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59644

Actions
Copy link
 #8

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59644

Actions
Copy link
 #9

Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59644

Actions
Copy link
 #10

Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59644

Actions
Copy link
 #11

Updated by Thomas Oliver Moll almost 6 years ago

Hi, would you please check if there is still a problem with the entry ['BBOX']['fileCacheHash']. I had to clear that one as well to get rid of all the additional files in assets/images when I implemented my workaround. (see https://forge.typo3.org/issues/87224#change-394579)

Actions
Copy link
 #12

Updated by Gerrit Code Review almost 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59644

Actions
Copy link
 #13

Updated by Gerrit Code Review almost 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59644

Actions
Copy link
 #14

Updated by Gerrit Code Review almost 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59644

Actions
Copy link
 #15

Updated by Gerrit Code Review almost 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59644

Actions
Copy link
 #16

Updated by Gerrit Code Review almost 6 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59644

Actions
Copy link
 #17

Updated by Ralph Brugger almost 6 years ago

Patch set 9 works great for us!

We've installed the 8.7.24 Update on Tuesday evening and hat after 24 hours 39 GB in:
typo3temp/assets/images

For some images we've had 2.000 copies.

Thanks!

Actions
Copy link
 #18

Updated by Gerrit Code Review almost 6 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59644

Actions
Copy link
 #19

Updated by Gerrit Code Review almost 6 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59644

Actions
Copy link
 #20

Updated by Gerrit Code Review almost 6 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59644

Actions
Copy link
 #21

Updated by Gerrit Code Review over 5 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59644

Actions
Copy link
 #22

Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59956

Actions
Copy link
 #23

Updated by Markus Klösges over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #24

Updated by Gerrit Code Review over 5 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59959

Actions
Copy link
 #25

Updated by Markus Klösges over 5 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #26

Updated by Gerrit Code Review over 5 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59959

Actions
Copy link
 #27

Updated by Markus Klösges over 5 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #28

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF