Bug #87031

colorpicker : pasted value is saved in database without formating/checking

Added by Filipe DA COSTA COSTA 12 days ago. Updated 3 days ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Backend JavaScript
Target version:
-
Start date:
2018-11-28
Due date:
% Done:

0%

TYPO3 Version:
8
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you paste a value into a colorpicker, some formating seems to be done but in reallity the raw value is saved in database.

A) Color missing hash (See attached Typo3ColorpickerIssueColor.gif)

  • Copy "00FF00"
  • Paste the value into colorpicker
  • Blur out of the input

The input value will visually change to "#00ff00".

  • Save page

The colorpicker displays "00FF00".

B) Random value (See attached Typo3ColorpickerIssue.gif)

  • Copy "NOT_A_COLOR"
  • Paste the value into colorpicker
  • Blur out of the input

The input value will visually be blank. If you have a "eval => required" you will notice that the red error will disappear.

  • Save page

The colorpicker displays "NOT_A_COLOR".

TCA configuration used for this example:

 'tx_apxsample_color' => [
        'exclude' => 1,
        'label'   => 'Color Hex Code',
        'config'  => [
            'type'       => 'input',
            'renderType' => 'colorpicker',
            'size'       => 10,
            'eval'       => 'required'
        ]
    ]

Typo3ColorpickerIssue.gif View (450 KB) Filipe DA COSTA COSTA, 2018-11-28 18:13

Typo3ColorpickerIssueColor.gif View (509 KB) Filipe DA COSTA COSTA, 2018-11-28 18:13

History

#1 Updated by Filipe DA COSTA COSTA 12 days ago

Adding the missing attachments

#2 Updated by Gerrit Code Review 3 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59052

#3 Updated by Gerrit Code Review 3 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59052

Also available in: Atom PDF