Bug #87052
closedsetDBinit configuration is still available in InstallTool
100%
Description
In TYPO3 8.7.20 InstallTool, there is still a configuration option for old $GLOBALS['TYPO3_CONF_VARS']['SYS']['setDBinit'].
This setting have no effect anymore (?) and leeds to use it without knowing its not used anymore :-(
Files
Updated by Steffen Mächtel over 5 years ago
Can in contribute and create a patch for this issue?
My suggestion is to remove this setting from InstallTool. I dont know if this has any downsides?
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59005
Updated by Gerrit Code Review over 5 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59006
Updated by Gerrit Code Review over 5 years ago
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59012
Updated by Steffen Mächtel over 5 years ago
Stefan Neufeind on Gerrit Code Review wrote:
SilentConfigurationUpgradeService.php (looked in 8.7) says the value is removed as SYS/setDBinit but moved to DB/Connections/Default/initCommands.
So to me it looks like it shouldn't finally be removed but instead by moved/renamed? Currently the silent-upgrader seems to handle that behind the scenes?
Stefan i tested an upgrade from 7.6.x to 8.7.20. Yes the silent-upgrade move the values from SYS/setDBinit to DB/Connections/Default/initCommands when u do the upgrade wizzard.
After you have done the upgrade wizzard. The option for edit SYS/setDBinit is still in the install tool > all configuration. Becouse its in DefaultConfiguration.
Same happens when you have a clean new 8.7 installation.
So my suggestion is to remove this from DefaultConfiguration (DefaultConfigurationDescription), so its no longer available inside install tool > all configuration.
I tested an upgrade from 7.6.x to 8.7.20 with the patch applied. The silent-upgrade still works and move the value to new location.
DB/* settings¶
Currently in 8.7 there are no options to change DB/* settings at all. Atleast i do not find them :) We can create new feature request to make all DB/* settings editibale in install tool (atleast for connection DEFAULT)?
Updated by Gerrit Code Review over 5 years ago
Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59006
Updated by Steffen Mächtel over 5 years ago
There are two more options in the DefaultConfiguration wich are are moved to new location:
- SYS/dbClientCompress
- SYS/no_pconnect
changing this value in install tool do not trigger silent upgrade process. They are written in LocalConfiguration and have no effect.
Updated by Gerrit Code Review over 5 years ago
Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59006
Updated by Stefan Neufeind over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 6d7c20064ceaf48879291dfd77a2e6346e403f96.