Bug #87082

Changes in type select (selectMultipleSideBySide) get lost when closing a record with no other changes

Added by Josef Glatz 9 days ago. Updated 6 days ago.

Status:
Resolved
Priority:
Must have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2018-12-04
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

87082.gif View (317 KB) Josef Glatz, 2018-12-07 19:42

Associated revisions

Revision 19ac9a7d (diff)
Added by Andreas Fernandez 6 days ago

[BUGFIX] Mark changes in `selectMultipleSideBySide`

A `selectMultipleSideBySide` field is now marked as "changed" when either
the order of items has changed or when an item has been removed.

Resolves: #87082
Releases: master, 8.7
Change-Id: I9f50576270db667751c14e3513d1a7cd31c1135e
Reviewed-on: https://review.typo3.org/59056
Reviewed-by: Josef Glatz <>
Tested-by: Josef Glatz <>
Tested-by: TYPO3com <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

Revision 3d841b80 (diff)
Added by Andreas Fernandez 6 days ago

[BUGFIX] Mark changes in `selectMultipleSideBySide`

A `selectMultipleSideBySide` field is now marked as "changed" when either
the order of items has changed or when an item has been removed.

Resolves: #87082
Releases: master, 8.7
Change-Id: I9f50576270db667751c14e3513d1a7cd31c1135e
Reviewed-on: https://review.typo3.org/59057
Reviewed-by: Richard Haeser <>
Reviewed-by: Josef Glatz <>
Tested-by: Josef Glatz <>
Tested-by: TYPO3com <>
Tested-by: Richard Haeser <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Andreas Fernandez 6 days ago

  • Status changed from Accepted to Needs Feedback

I fail to reproduce the issue. I've opened a "Backend User Group" record, changed the "Inherit settings from groups" field only (as it's selectMultipleSideBySide) and clicked the "Close" button. FormEngine renders a confirmation modal to me.

#2 Updated by Josef Glatz 6 days ago

  • File 87082.gif View added
  • Status changed from Needs Feedback to Accepted

How to reproduce:

#3 Updated by Gerrit Code Review 6 days ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59056

#4 Updated by Gerrit Code Review 6 days ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59057

#5 Updated by Andreas Fernandez 6 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF