Bug #87187

Upgrade wizard ignores step "Update database schema" if an SQL error occurs

Added by Nicole Cordes almost 2 years ago. Updated 7 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2018-12-17
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Given:

- an upgrade from 7.6.32 to 8.7.21
- an extension with wrong SQL in ext_tables.sql

```
CREATE TABLE tx_foo_domain_model_bar (
fetched boolean DEFAULT '1' NOT NULL,
);
```

Expected:

- an error should be shown anywhere

Actual:

- the step "Update database schema" is silently skipped resulting in a fatal error because of missing l10n_source field in tt_content

Associated revisions

Revision c967c997 (diff)
Added by Nicole Cordes 7 months ago

[BUGFIX] Catch error in database Upgrade Wizard

If an extension provides wrong SQL in ext_tables.sql, the upgrade
wizard is skipped completely. This patch catches the current
exception and outputs the error that needs to be resolved manually.

Resolves: #87187
Releases: master, 9.5
Change-Id: I903ce7fdc9373eee66da7bed86698c42a2731dc7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59182
Reviewed-by: Benni Mack <>
Reviewed-by: Markus Klein <>
Reviewed-by: Susanne Moog <>
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Tested-by: Susanne Moog <>

Revision f1685c23 (diff)
Added by Nicole Cordes 7 months ago

[BUGFIX] Catch error in database Upgrade Wizard

If an extension provides wrong SQL in ext_tables.sql, the upgrade
wizard is skipped completely. This patch catches the current
exception and outputs the error that needs to be resolved manually.

Resolves: #87187
Releases: master, 9.5
Change-Id: I903ce7fdc9373eee66da7bed86698c42a2731dc7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63912
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Reviewed-by: Susanne Moog <>

History

#1 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59182

#2 Updated by Nicole Cordes almost 2 years ago

  • Description updated (diff)

#3 Updated by Nicole Cordes almost 2 years ago

  • Description updated (diff)

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59182

#5 Updated by Christian Eßl about 1 year ago

  • Category set to Install Tool

#6 Updated by Gerrit Code Review 7 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59182

#7 Updated by Gerrit Code Review 7 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63912

#8 Updated by Nicole Cordes 7 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Benni Mack 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF