Bug #87216

Epic #87193: Remove deprecated code from the core

Task #87202: Remove deprecated code from Bootstrap

Left-over code in SystemEnvironmentBuilder missed during Bootstrap deprecation removal

Added by Benjamin Franzke 9 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Start date:
2018-12-19
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Associated revisions

Revision 850e87f8 (diff)
Added by Benjamin Franzke 9 months ago

[BUGFIX] Update redefinition guard comments in SystemEnvironmentBuilder

These constant redefintion guards were forgotten to be updated when
Bootstrap::getInstance() and the call to SystemEnvironmentBuilder::run()
in Bootstrap::baseSetup() were removed.

These guards are no longer necessary for regular execution as baseSetup()
does no longer (conditionally) invoke SystemEnvironmentBuilder::run()
(which was provided for deprecated and now removed bootstrapping code).

We do still leave the guards in, as they are needed in unit tests,
but update the comments.

Releases: master
Resolves: #87216
Related: #87202
Change-Id: I3b1c60ea32163d68b7f314b6539c54d8c048c323
Reviewed-on: https://review.typo3.org/59214
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59214

#2 Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59214

#3 Updated by Benjamin Franzke 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF