Task #87202

Epic #87193: Remove deprecated code from the core

Remove deprecated code from Bootstrap

Added by Benjamin Franzke 9 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Start date:
2018-12-19
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Subtasks

Bug #87216: Left-over code in SystemEnvironmentBuilder missed during Bootstrap deprecation removalClosed


Related issues

Related to TYPO3 Core - Bug #87212: Remove unused argument $entryPointLevel from Bootstrap Closed 2018-12-19

Associated revisions

Revision 23df8e26 (diff)
Added by Benjamin Franzke 9 months ago

[!!!][TASK] Remove deprecated code from Bootstrap

Remove code that is not needed due to the static bootstrap
and PSR-15 refactoring during v9 phase.

All deprecated methods and state is removed from the Bootstrap class,
which includes the Bootstrap instance itself. Bootstrap is provided as
statically invoked utility now.
The Bootstrap instance was deprecated implictly due to the deprecation
of getInstance() (combined with the protected constructor).
We therefore remove the constructor and all (now unused) class properties
and the method-chaining (which was only useful to reduce calls to the
getInstance() method).

Releases: master
Resolves: #87202
Change-Id: Ie97e824294a03d8de88430772fdab4adaf7e3f1f
Reviewed-on: https://review.typo3.org/59196
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision 70f3a1af (diff)
Added by Christian Kuhn 9 months ago

[BUGFIX] Remove unused argument $entryPointLevel from Bootstrap

The argument is optional and can be removed without
further notice.

Resolves: #87212
Related: #87202
Releases: master
Change-Id: I667a091b84986111562a581c0bb22d29f624fd19
Reviewed-on: https://review.typo3.org/59211
Reviewed-by: Benjamin Franzke <>
Tested-by: Benjamin Franzke <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

Revision 850e87f8 (diff)
Added by Benjamin Franzke 9 months ago

[BUGFIX] Update redefinition guard comments in SystemEnvironmentBuilder

These constant redefintion guards were forgotten to be updated when
Bootstrap::getInstance() and the call to SystemEnvironmentBuilder::run()
in Bootstrap::baseSetup() were removed.

These guards are no longer necessary for regular execution as baseSetup()
does no longer (conditionally) invoke SystemEnvironmentBuilder::run()
(which was provided for deprecated and now removed bootstrapping code).

We do still leave the guards in, as they are needed in unit tests,
but update the comments.

Releases: master
Resolves: #87216
Related: #87202
Change-Id: I3b1c60ea32163d68b7f314b6539c54d8c048c323
Reviewed-on: https://review.typo3.org/59214
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59196

#2 Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59196

#3 Updated by Gerrit Code Review 9 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59196

#4 Updated by Gerrit Code Review 9 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59196

#5 Updated by Benjamin Franzke 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Christian Kuhn 9 months ago

  • Related to Bug #87212: Remove unused argument $entryPointLevel from Bootstrap added

#7 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF