Bug #87283

Install tool: Marking row updater as undone not possible

Added by Thorben Nissen 9 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Install Tool
Target version:
Start date:
2018-12-23
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

When trying to mark a single row updater as undone, an exception `No valid wizard identifier given` is thrown.

This happens, because the `UpgradeWizardService::assertIdentifierIsValid` only checks registered update wizard, but not the row updaters.

This happens in v9 and current master, but not in v8. This was introduced with the refactoring of the install tool and upgrade wizards.


Related issues

Related to TYPO3 Core - Bug #87156: Database row upgrade wizard can not be marked undone Closed 2018-12-14

Associated revisions

Revision 3b84e613 (diff)
Added by Thorben Nissen 9 months ago

[BUGFIX] Install tool: Allow row updater as valid identifier

In `UpgradeWizardService::assertIdentifierIsValid` check if the
identifier is a subclass of `RowUpdaterInterface` to avoid an exception
being thrown, when marking a row updater as undone.

Resolves: #87283
Releases: master, 9.5
Change-Id: I1b6a18437aa9d5a423c0a47595feac8b51c28bdb
Reviewed-on: https://review.typo3.org/59290
Tested-by: TYPO3com <>
Reviewed-by: Daniel Gorges <>
Tested-by: Daniel Gorges <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision 35085715 (diff)
Added by Thorben Nissen 9 months ago

[BUGFIX] Install tool: Allow row updater as valid identifier

In `UpgradeWizardService::assertIdentifierIsValid` check if the
identifier is a subclass of `RowUpdaterInterface` to avoid an exception
being thrown, when marking a row updater as undone.

Resolves: #87283
Releases: master, 9.5
Change-Id: I1b6a18437aa9d5a423c0a47595feac8b51c28bdb
Reviewed-on: https://review.typo3.org/59383
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Thorben Nissen 9 months ago

  • Description updated (diff)

#2 Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59290

#3 Updated by Gerrit Code Review 9 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59383

#4 Updated by Thorben Nissen 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Mona Muzaffar 8 months ago

  • Related to Bug #87156: Database row upgrade wizard can not be marked undone added

#6 Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF