Task #87396

Epic #87395: Remove obsolete condition checks in unit tests

Checks for CRYPT_MD5 and CRYPT_BLOWFISH availability are obsolete

Added by Stefanos Karasavvidis 10 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Tests
Target version:
-
Start date:
2019-01-11
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

According to crypt() documentation "As of PHP 5.3.0, PHP contains its own implementation and will use that if the system lacks of support for one or more of the algorithms."

So in unit tests, the check for the availability of those 2 are not necessary in files

typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Md5PasswordHashTest.php
typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/BlowfishPasswordHashTest.php

Associated revisions

Revision faa53b8e (diff)
Added by Stefanos Karasavvidis 10 months ago

[TASK] Remove checks for CRYPT_MD5 and CRYPT_BLOWFISH availability

According to crypt() documentation "As of PHP 5.3.0, PHP contains its
own implementation and will use that if the system lacks of support
for one or more of the algorithms.". So these checks are not
necessary anymore.

Resolves: #87396
Releases: master, 9.5
Change-Id: I6ddede477283a39349e4c4d8d5f464435c855b85
Reviewed-on: https://review.typo3.org/59399
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

Revision edabf59f (diff)
Added by Stefanos Karasavvidis 10 months ago

[TASK] Remove checks for CRYPT_MD5 and CRYPT_BLOWFISH availability

According to crypt() documentation "As of PHP 5.3.0, PHP contains its
own implementation and will use that if the system lacks of support
for one or more of the algorithms.". So these checks are not
necessary anymore.

Resolves: #87396
Releases: master, 9.5
Change-Id: I6ddede477283a39349e4c4d8d5f464435c855b85
Reviewed-on: https://review.typo3.org/59404
Tested-by: TYPO3com <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

History

#1 Updated by Stefanos Karasavvidis 10 months ago

  • Category set to Tests

#2 Updated by Anja Leichsenring 10 months ago

  • Parent task set to #87395

#3 Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59399

#4 Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59399

#5 Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59404

#6 Updated by Stefanos Karasavvidis 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF