Task #87397

Epic #87395: Remove obsolete condition checks in unit tests

Checks for vfsStream availability should be removed in tests

Added by Stefanos Karasavvidis 8 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Tests
Target version:
-
Start date:
2019-01-11
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

In several tests, the availability of vfsStream or it's classes and methods is checked. vfsStream is required and thus should be available in all installations. The checks should be removed

typo3/sysext/core/Tests/Unit/Cache/Backend/FileBackendTest.php
typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php
typo3/sysext/core/Tests/Unit/Log/Writer/FileWriterTest.php
typo3/sysext/core/Tests/Unit/Resource/BaseTestCase.php

Associated revisions

Revision bbea0b49 (diff)
Added by Stefanos Karasavvidis 8 months ago

[TASK] Remove checks for vfsStream availability

vfsStream and it's classes and methods are required anyway
and thus there is no need to check for it's existence.

Resolves: #87397
Releases: master
Change-Id: I342c3690217823d138ab98a00692de055f8d7fe8
Reviewed-on: https://review.typo3.org/59401
Tested-by: TYPO3com <>
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>

Revision 72fd7f38 (diff)
Added by Stefanos Karasavvidis 8 months ago

[TASK] Remove checks for vfsStream availability

vfsStream and it's classes and methods are required anyway
and thus there is no need to check for it's existence.

Resolves: #87397
Releases: master, 9.5
Change-Id: I342c3690217823d138ab98a00692de055f8d7fe8
Reviewed-on: https://review.typo3.org/59402
Tested-by: TYPO3com <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Stefanos Karasavvidis 8 months ago

  • Category set to Tests

#2 Updated by Anja Leichsenring 8 months ago

  • Parent task set to #87395

#3 Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59401

#4 Updated by Gerrit Code Review 8 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59402

#5 Updated by Anonymous 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Gerrit Code Review 8 months ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59402

#7 Updated by Gerrit Code Review 8 months ago

Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59402

#8 Updated by Stefanos Karasavvidis 8 months ago

  • Status changed from Under Review to Resolved

#9 Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF