Project

General

Profile

Actions

Task #87398

closed

Epic #87395: Remove obsolete condition checks in unit tests

The check for MacOS in case posix_getegid() is used, is obsolete

Added by Stefanos Karasavvidis almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Tests
Target version:
-
Start date:
2019-01-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

On tests that involve posix_getegid(), it is checked whether it returns -1, because on MacOS it is said to return always -1.
This is not the case (anymore?) on MacOS, and thus the check should be removed or the skip message changed.

typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php

Actions #1

Updated by Stefanos Karasavvidis almost 6 years ago

  • Category set to Tests
Actions #2

Updated by Anja Leichsenring almost 6 years ago

  • Parent task set to #87395
Actions #3

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59403

Actions #4

Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59405

Actions #5

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59403

Actions #6

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59405

Actions #7

Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59405

Actions #8

Updated by Stefanos Karasavvidis almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF