Task #87398

Epic #87395: Remove obsolete condition checks in unit tests

The check for MacOS in case posix_getegid() is used, is obsolete

Added by Stefanos Karasavvidis 2 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Tests
Target version:
-
Start date:
2019-01-11
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

On tests that involve posix_getegid(), it is checked whether it returns -1, because on MacOS it is said to return always -1.
This is not the case (anymore?) on MacOS, and thus the check should be removed or the skip message changed.

typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php

Associated revisions

Revision 8decb608 (diff)
Added by Stefanos Karasavvidis 2 months ago

[TASK] Remove check for posix_getegid returning -1

On MacOS posix_getegid does return a correct effective group id, so
the check can be removed. Windows systems are already excluded by
other checks.

Resolves: #87398
Releases: master, 9.5
Change-Id: Ic1bff8d11f9109806a61351d992bfd471ebd4a8d
Reviewed-on: https://review.typo3.org/59403
Reviewed-by: Mona Muzaffar <>
Tested-by: Mona Muzaffar <>
Tested-by: TYPO3com <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

Revision 7b74c036 (diff)
Added by Stefanos Karasavvidis 2 months ago

[TASK] Remove check for posix_getegid returning -1

On MacOS posix_getegid does return a correct effective group id, so
the check can be removed. Windows systems are already excluded by
other checks.

Resolves: #87398
Releases: master, 9.5
Change-Id: Ic1bff8d11f9109806a61351d992bfd471ebd4a8d
Reviewed-on: https://review.typo3.org/59405
Tested-by: TYPO3com <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Stefanos Karasavvidis 2 months ago

  • Category set to Tests

#2 Updated by Anja Leichsenring 2 months ago

  • Parent task set to #87395

#3 Updated by Gerrit Code Review 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59403

#4 Updated by Gerrit Code Review 2 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59405

#5 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59403

#6 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59405

#7 Updated by Gerrit Code Review 2 months ago

Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59405

#8 Updated by Stefanos Karasavvidis 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF