Bug #87576

File Storage `name` field is needlessly very short (30 characters)

Added by Leonie Philine Bitto 10 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend User Interface
Target version:
Start date:
2019-01-29
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
7.3
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

TCA for sys_file_storage:

        'name' => [
            'label' => 'LLL:EXT:lang/Resources/Private/Language/locallang_tca.xlf:sys_file_storage.name',
            'config' => [
                'type' => 'input',
                'size' => 30,
                'eval' => 'required'
            ]
        ],

in comparison, Filemounts have a sane title length:

        'title' => [
            'label' => 'LLL:EXT:lang/Resources/Private/Language/locallang_tca.xlf:sys_filemounts.title',
            'config' => [
                'type' => 'input',
                'size' => 50,
                'max' => 255,
                'eval' => 'required,trim'
            ]
        ],

There is absolutely no reason to have a storage name field of such a short length! (If you can come up with any - please enlighten me.)

When using FAL secure storages ("Access > Publicly available?" = NO), optionally with EXT:fal_securedownload, then 30 characters quickly become too short if you have a multi-word site title and want to add e.g. "(secure)" to the name.

In any case, 30 characters is short for no reason, and fixing it is a no-brainer.

Associated revisions

Revision 14a1fdc9 (diff)
Added by Georg Ringer 10 months ago

[TASK] Increase field name of table sys_file_storage

Increase the length of the field from 30 to 255 chars to be in
sync with other tables, e.g. sys_file_mounts. 30 is fairly short
for bigger sites and lots of storages.

As this is an admin only field and not too often used, it is ok to backport
that to 9.5 as well.

Resolves: #87576
Releases: master, 9.5
Change-Id: I355b6295a9f813e72e1e66e05dd93419fd2aeaeb
Reviewed-on: https://review.typo3.org/59581
Reviewed-by: Benni Mack <>
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 1c2d76c0 (diff)
Added by Georg Ringer 10 months ago

[TASK] Increase field name of table sys_file_storage

Increase the length of the field from 30 to 255 chars to be in
sync with other tables, e.g. sys_file_mounts. 30 is fairly short
for bigger sites and lots of storages.

As this is an admin only field and not too often used, it is ok to backport
that to 9.5 as well.

Resolves: #87576
Releases: master, 9.5
Change-Id: I355b6295a9f813e72e1e66e05dd93419fd2aeaeb
Reviewed-on: https://review.typo3.org/59587
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Georg Ringer 10 months ago

  • Category changed from File Abstraction Layer (FAL) to Backend User Interface
  • Status changed from New to Accepted
  • Assignee set to Georg Ringer

This won't be fixed in 8 anymore but with 2 files and 5min time you can fix that with e.g. our site package extension.

#2 Updated by Gerrit Code Review 10 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59581

#3 Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59587

#4 Updated by Georg Ringer 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF