Bug #87619

Hardened ImageService throws error in ImageViewHelper

Added by André Schließer 5 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Must have
Category:
-
Target version:
-
Start date:
2019-02-01
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

With the merge of https://review.typo3.org/#/c/59594/ and an ImageViewHelper which sends null to ImageService::getImage() following error is thrown:

Argument 1 passed to TYPO3\CMS\Extbase\Service\ImageService::getImage() must be of the type string, null given, called in /var/www/html/typo3/sysext/fluid/Classes/ViewHelpers/Uri/ImageViewHelper.php on line 112

Related issues

Related to TYPO3 Core - Task #87599: Harden \TYPO3\CMS\Extbase\Service\ImageService Closed 2019-01-31

Associated revisions

Revision a59e232b (diff)
Added by Anja Leichsenring 5 months ago

[BUGFIX] Ensure type safety for ViewHelper calling ImageService

The ImageService::getImage requires a string as first and a boolean as
third parameter. The Image ViewHelpers must respect this requirement.

Resolves: #87619
Relates: #87599
Releases: master
Change-Id: I0d8f57c2bef62dcc6b4d6e6684bbbb1593bff98f
Reviewed-on: https://review.typo3.org/59608
Reviewed-by: Alexander Schnitzler <>
Tested-by: Alexander Schnitzler <>
Tested-by: TYPO3com <>
Reviewed-by: Andreas Wolf <>
Reviewed-by: André Schließer <>
Tested-by: André Schließer <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59608

#2 Updated by Anja Leichsenring 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Anja Leichsenring 5 months ago

  • Related to Task #87599: Harden \TYPO3\CMS\Extbase\Service\ImageService added

#4 Updated by Benni Mack 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF