Bug #87622

Minimum required prophecy version is incompatible with object (return) type declarations

Added by Benjamin Franzke 5 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Start date:
2019-02-02
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Recent changes like https://review.typo3.org/c/59600/ introduced object return type decarations which are only supported as of prophecy version 1.7.5.
This caused nightly, composer minimum builds, to fail: https://bamboo.typo3.com/browse/CORE-GTN-UT2PHP72-646

Therefore the default minimum – as required by phpunit (^1.7) – needs to be raised to 1.7.5.


Related issues

Related to TYPO3 Core - Task #87605: Harden \TYPO3\CMS\Extbase\Object\ObjectManager Closed 2019-01-31

Associated revisions

Revision f4a292cc (diff)
Added by Benjamin Franzke 5 months ago

[BUGFIX] Raise minimum required prophecy version to 1.7.5

The recently introduced `object` type declarations for extbase classes
require a minimum version of prophecy 1.7.5. Previous versions trigger
the following error:
Scalar type declaration 'object' must be unqualified

Prophecy added support for object type declarations in 1.7.4 and
for return type object declarations in 1.7.5.

Therefore we add an explicit dev dependency to prophecy in composer.json
now (previously it was transitively required as ^1.7 by phpunit 7.1).

composer require --no-update --dev phpspec/prophecy:^1.7.5
composer update --lock

Releases: master
Resolves: #87622
Change-Id: Ic35db424d1ea46143839ec3f4bd3c10e39c99b4e
Reviewed-on: https://review.typo3.org/59620
Reviewed-by: Alexander Schnitzler <>
Tested-by: Alexander Schnitzler <>
Tested-by: TYPO3com <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59620

#2 Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59620

#3 Updated by Anja Leichsenring 5 months ago

  • Related to Task #87605: Harden \TYPO3\CMS\Extbase\Object\ObjectManager added

#4 Updated by Gerrit Code Review 5 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59620

#5 Updated by Gerrit Code Review 5 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59620

#6 Updated by Gerrit Code Review 5 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59620

#7 Updated by Benjamin Franzke 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF