Bug #87632

Do not treat all classes as entities

Added by Alexander Schnitzler 7 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Category:
Extbase
Start date:
2019-02-04
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Currently, ClassSchema has a property modelType which is set to a value by default that defines that the class the class schema is generated for is an entity.
This however is wrong as most classes aren't entities and therefore don't need to consume the extra cpu cycles to check for entity related annotations and so on.


Related issues

Related to TYPO3 Core - Bug #87773: ClassSchema doesn't treat unsignated classes anymore Closed 2019-02-24

Associated revisions

Revision 7b320c72 (diff)
Added by Alexander Schnitzler 6 months ago

[BUGFIX] Do not treat all classes as entities in ClassSchema

The ClassSchema class has a property $modelType which indicates
that a class is either an entity or a value object. This property
has a default value that reflected the state of an entity.

This means, that all classes, class schemata are created for are
considered entities which then leads to the execution of further
entity related analysis code, such as looking for specific doc
blocks and/or annotations.

While this isn't an issue functionality wise, it can be in the future.
Also, the superfluous cpu cycles can and should be spared.

Releases: master, 9.5
Resolves: #87632
Change-Id: If4bc79b9761ee28ffd9e2f25924588140310c0fa
Reviewed-on: https://review.typo3.org/c/59628
Reviewed-by: Susanne Moog <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Susanne Moog <>
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>

Revision fad65324 (diff)
Added by Alexander Schnitzler 6 months ago

[BUGFIX] Do not treat all classes as entities in ClassSchema

The ClassSchema class has a property $modelType which indicates
that a class is either an entity or a value object. This property
has a default value that reflected the state of an entity.

This means, that all classes, class schemata are created for are
considered entities which then leads to the execution of further
entity related analysis code, such as looking for specific doc
blocks and/or annotations.

While this isn't an issue functionality wise, it can be in the future.
Also, the superfluous cpu cycles can and should be spared.

Releases: master, 9.5
Resolves: #87632
Change-Id: If4bc79b9761ee28ffd9e2f25924588140310c0fa
Reviewed-on: https://review.typo3.org/c/59792
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Anja Leichsenring <>

Revision b1fa8e85 (diff)
Added by Alexander Schnitzler 5 months ago

[BUGFIX] Do not treat all classes as entities in ClassSchema

The ClassSchema class has a property $modelType which indicates
that a class is either an entity or a value object. This property
has a default value that reflected the state of an entity.

This means, that all classes, class schemata are created for are
considered entities which then leads to the execution of further
entity related analysis code, such as looking for specific doc
blocks and/or annotations.

While this isn't an issue functionality wise, it can be in the future.
Also, the superfluous cpu cycles can and should be spared.

Releases: master, 9.5
Resolves: #87632
Change-Id: I15f7688b8bf1ac9486d77a0efc38ccb07a397b30
Reviewed-on: https://review.typo3.org/c/59806
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Anja Leichsenring <>

Revision 57527493 (diff)
Added by Alexander Schnitzler 5 months ago

[BUGFIX] Do not treat all classes as entities in ClassSchema

The ClassSchema class has a property $modelType which indicates
that a class is either an entity or a value object. This property
has a default value that reflected the state of an entity.

This means, that all classes, class schemata are created for are
considered entities which then leads to the execution of further
entity related analysis code, such as looking for specific doc
blocks and/or annotations.

While this isn't an issue functionality wise, it can be in the future.
Also, the superfluous cpu cycles can and should be spared.

Releases: master, 9.5
Resolves: #87632
Change-Id: I15f7688b8bf1ac9486d77a0efc38ccb07a397b30
Reviewed-on: https://review.typo3.org/c/59912
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59628

#2 Updated by Gerrit Code Review 6 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59628

#3 Updated by Anonymous 6 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Gerrit Code Review 6 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59792

#5 Updated by Gerrit Code Review 6 months ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59792

#6 Updated by Anonymous 6 months ago

  • Status changed from Under Review to Resolved

#7 Updated by Anja Leichsenring 6 months ago

  • Related to Bug #87773: ClassSchema doesn't treat unsignated classes anymore added

#8 Updated by Gerrit Code Review 6 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59806

#9 Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59912

#10 Updated by Anonymous 5 months ago

  • Status changed from Under Review to Resolved

#11 Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF