Project

General

Profile

Actions

Bug #87728

closed

LinkBuilder on pages with site configuration should not ignore setNoCache

Added by Rozbeh Chiryai Sharahi almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Start date:
2019-02-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
medium
Is Regression:
Sprint Focus:

Description

Hello,

i just realized that

\TYPO3\CMS\Frontend\Typolink\PageLinkBuilder::build

will ignore
$conf['no_cache']=1

if we are in the context of a page with site configuration.

Suggestion:

1) Create Functional Test for \TYPO3\CMS\Frontend\Typolink\PageLinkBuilder or for \TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder that will check for `no_cache` parameter to be set.

2) Add something like:

if($conf['no_cache']) {
  $queryParameters['no_cache'] = 1
}

to
\TYPO3\CMS\Frontend\Typolink\PageLinkBuilder::generateUrlForPageWithSiteConfiguration

Reproduce:

On any page with site configuration in any controller action do following:

$this->uriBuilder->reset()->setTargetPageUid(123)->setNoCache(true)->build();

Kind regards
Rozbeh Chiryai Sharahi

Actions #1

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59715

Actions #2

Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59791

Actions #3

Updated by Georg Ringer over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF