Bug #87728
closedLinkBuilder on pages with site configuration should not ignore setNoCache
100%
Description
Hello,
i just realized that
\TYPO3\CMS\Frontend\Typolink\PageLinkBuilder::build
will ignore
$conf['no_cache']=1
if we are in the context of a page with site configuration.
Suggestion:
1) Create Functional Test for \TYPO3\CMS\Frontend\Typolink\PageLinkBuilder or for \TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder that will check for `no_cache` parameter to be set.
2) Add something like:
if($conf['no_cache']) {
$queryParameters['no_cache'] = 1
}
to
\TYPO3\CMS\Frontend\Typolink\PageLinkBuilder::generateUrlForPageWithSiteConfiguration
Reproduce:
On any page with site configuration in any controller action do following:
$this->uriBuilder->reset()->setTargetPageUid(123)->setNoCache(true)->build();
Kind regards
Rozbeh Chiryai Sharahi
Updated by Gerrit Code Review almost 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59715
Updated by Gerrit Code Review over 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59791
Updated by Georg Ringer over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 409a6e40c87a4d185dd3bd1b328ff5d4fb5cba63.