Project

General

Profile

Actions
Copy link

Bug #87728

closed

LinkBuilder on pages with site configuration should not ignore setNoCache

Added by Rozbeh Chiryai Sharahi almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
Candidate for Major Version
Start date:
2019-02-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
medium
Is Regression:
Sprint Focus:

Description

Hello,

i just realized that 

\TYPO3\CMS\Frontend\Typolink\PageLinkBuilder::build

will ignore 
$conf['no_cache']=1

if we are in the context of a page with site configuration.

Suggestion:

1) Create Functional Test for \TYPO3\CMS\Frontend\Typolink\PageLinkBuilder or for \TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder that will check for `no_cache` parameter to be set.

2) Add something like:

if($conf['no_cache']) {
  $queryParameters['no_cache'] = 1
}

to 
\TYPO3\CMS\Frontend\Typolink\PageLinkBuilder::generateUrlForPageWithSiteConfiguration

Reproduce:

On any page with site configuration in any controller action do following:

$this->uriBuilder->reset()->setTargetPageUid(123)->setNoCache(true)->build();

Kind regards
Rozbeh Chiryai Sharahi

Actions
Copy link

Also available in: Atom PDF