Bug #87772

validateRstFiles Script does not recognize Features for stable branches

Added by Anja Leichsenring 3 months ago. Updated 20 days ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2019-02-23
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The script should check rst files for necessary parts, but it is a little bit too greedy. Features and Important files do not require a *Scanned index entry, but this is currently ignored.

This would be valid file pathes, where no *Scanned index entries are required:

typo3/sysext/core/Documentation/Changelog/9.5.1/Feature-87748-AddSiteProcessor.rst
typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-87748-AddSiteProcessor.rst
typo3/sysext/core/Documentation/Changelog/master/Feature-87748-AddSiteProcessor.rst
typo3/sysext/core/Documentation/Changelog/9.5/Feature-87748-AddSiteProcessor.rst


Related issues

Related to TYPO3 Core - Task #87774: Adjust rst file indizes for proper validation Closed 2019-02-24

Associated revisions

Revision 8e64eda6 (diff)
Added by Anja Leichsenring 3 months ago

[BUGFIX] Relax rst validation rules for Feature and Important

When looking for FullyScanned|PartiallyScanned|NotScanned ignore Feature
and Important rst files from any version as well as all rst files from
7.x and 8.x

Resolves: #87772
Releases: master, 9.5, 8.7
Change-Id: I7bf2a6068f95603a8ac3e6df4cb336d66963f145
Reviewed-on: https://review.typo3.org/c/59790
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Jürgen Venne <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Jürgen Venne <>
Reviewed-by: Anja Leichsenring <>

Revision d38dbd6f (diff)
Added by Anja Leichsenring 3 months ago

[BUGFIX] Relax rst validation rules for Feature and Important

When looking for FullyScanned|PartiallyScanned|NotScanned ignore Feature
and Important rst files from any version as well as all rst files from
7.x and 8.x

Resolves: #87772
Releases: master, 9.5, 8.7
Change-Id: I7bf2a6068f95603a8ac3e6df4cb336d66963f145
Reviewed-on: https://review.typo3.org/c/59818
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Anja Leichsenring <>

Revision 78a83367 (diff)
Added by Anja Leichsenring 3 months ago

[BUGFIX] Relax rst validation rules for Feature and Important

When looking for FullyScanned|PartiallyScanned|NotScanned ignore Feature
and Important rst files from any version as well as all rst files from
7.x and 8.x

Resolves: #87772
Releases: master, 9.5, 8.7
Change-Id: I7bf2a6068f95603a8ac3e6df4cb336d66963f145
Reviewed-on: https://review.typo3.org/c/59819
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790

#2 Updated by Gerrit Code Review 3 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790

#3 Updated by Stephan Großberndt 3 months ago

typo3/sysext/core/Documentation/Changelog/9.5.1/Feature-87748-AddSiteProcessor.rst

is not valid, the others are valid.

#4 Updated by Stephan Großberndt 3 months ago

$filenames = [

    'typo3/sysext/core/Documentation/Changelog/master/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst',
    'typo3/sysext/core/Documentation/Changelog/master/Feature-58637-PurgeLanguagePacksInLanguageModule.rst',
    'typo3/sysext/core/Documentation/Changelog/9.5.x/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst',
    'typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-58637-PurgeLanguagePacksInLanguageModule.rst',
    'typo3/sysext/core/Documentation/Changelog/9.5/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst',
    'typo3/sysext/core/Documentation/Changelog/9.5/Feature-58637-PurgeLanguagePacksInLanguageModule.rst',
    'typo3/sysext/core/Documentation/Changelog/8.7.x/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst',
    'typo3/sysext/core/Documentation/Changelog/8.7.x/Feature-58637-PurgeLanguagePacksInLanguageModule.rst',
    'typo3/sysext/core/Documentation/Changelog/8.7/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst',
    'typo3/sysext/core/Documentation/Changelog/8.7/Feature-58637-PurgeLanguagePacksInLanguageModule.rst',

    'typo3/sysext/core/Documentation/Changelog/9.5.1/Feature-87748-AddSiteProcessor.rst',
    'typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-87748-AddSiteProcessor.rst',
    'typo3/sysext/core/Documentation/Changelog/master/Feature-87748-AddSiteProcessor.rst',
    'typo3/sysext/core/Documentation/Changelog/9.5/Feature-87748-AddSiteProcessor.rst',
];

foreach ($filenames as $filename) {
    echo preg_match('#'
            . 'Changelog/'             # Ignore all Changelog files
            . '('                      # which are either
            . '.+/(Feature|Important)' # of type "Feature" and "Important" from any version
            . '|'                      # or
            . '([78]\.\d(\.[0-9x])?)'  # from 7.x and 8.x (as there was no extension scanner back then)
            . ')'
            . '#x', $filename) . ' ' . $filename . PHP_EOL;
}

0 typo3/sysext/core/Documentation/Changelog/master/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst
1 typo3/sysext/core/Documentation/Changelog/master/Feature-58637-PurgeLanguagePacksInLanguageModule.rst
0 typo3/sysext/core/Documentation/Changelog/9.5.x/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst
1 typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-58637-PurgeLanguagePacksInLanguageModule.rst
0 typo3/sysext/core/Documentation/Changelog/9.5/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst
1 typo3/sysext/core/Documentation/Changelog/9.5/Feature-58637-PurgeLanguagePacksInLanguageModule.rst
1 typo3/sysext/core/Documentation/Changelog/8.7.x/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst
1 typo3/sysext/core/Documentation/Changelog/8.7.x/Feature-58637-PurgeLanguagePacksInLanguageModule.rst
1 typo3/sysext/core/Documentation/Changelog/8.7/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst
1 typo3/sysext/core/Documentation/Changelog/8.7/Feature-58637-PurgeLanguagePacksInLanguageModule.rst
1 typo3/sysext/core/Documentation/Changelog/9.5.1/Feature-87748-AddSiteProcessor.rst
1 typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-87748-AddSiteProcessor.rst
1 typo3/sysext/core/Documentation/Changelog/master/Feature-87748-AddSiteProcessor.rst
1 typo3/sysext/core/Documentation/Changelog/9.5/Feature-87748-AddSiteProcessor.rst

#5 Updated by Gerrit Code Review 3 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790

#6 Updated by Gerrit Code Review 3 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790

#7 Updated by Gerrit Code Review 3 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790

#8 Updated by Anja Leichsenring 3 months ago

  • Related to Task #87774: Adjust rst file indizes for proper validation added

#9 Updated by Gerrit Code Review 3 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790

#10 Updated by Gerrit Code Review 3 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790

#11 Updated by Gerrit Code Review 3 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790

#12 Updated by Gerrit Code Review 3 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59818

#13 Updated by Gerrit Code Review 3 months ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59819

#14 Updated by Anonymous 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#15 Updated by Benni Mack 20 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF