Bug #87772
closed
validateRstFiles Script does not recognize Features for stable branches
Added by Anja Leichsenring over 5 years ago. Updated over 5 years ago.
100%
Description
The script should check rst files for necessary parts, but it is a little bit too greedy. Features and Important files do not require a *Scanned index entry, but this is currently ignored.
This would be valid file pathes, where no *Scanned index entries are required:
typo3/sysext/core/Documentation/Changelog/9.5.1/Feature-87748-AddSiteProcessor.rst
typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-87748-AddSiteProcessor.rst
typo3/sysext/core/Documentation/Changelog/master/Feature-87748-AddSiteProcessor.rst
typo3/sysext/core/Documentation/Changelog/9.5/Feature-87748-AddSiteProcessor.rst
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790
Updated by Gerrit Code Review over 5 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790
Updated by Stephan Großberndt over 5 years ago
typo3/sysext/core/Documentation/Changelog/9.5.1/Feature-87748-AddSiteProcessor.rst
is not valid, the others are valid.
Updated by Stephan Großberndt over 5 years ago
$filenames = [
'typo3/sysext/core/Documentation/Changelog/master/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst',
'typo3/sysext/core/Documentation/Changelog/master/Feature-58637-PurgeLanguagePacksInLanguageModule.rst',
'typo3/sysext/core/Documentation/Changelog/9.5.x/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst',
'typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-58637-PurgeLanguagePacksInLanguageModule.rst',
'typo3/sysext/core/Documentation/Changelog/9.5/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst',
'typo3/sysext/core/Documentation/Changelog/9.5/Feature-58637-PurgeLanguagePacksInLanguageModule.rst',
'typo3/sysext/core/Documentation/Changelog/8.7.x/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst',
'typo3/sysext/core/Documentation/Changelog/8.7.x/Feature-58637-PurgeLanguagePacksInLanguageModule.rst',
'typo3/sysext/core/Documentation/Changelog/8.7/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst',
'typo3/sysext/core/Documentation/Changelog/8.7/Feature-58637-PurgeLanguagePacksInLanguageModule.rst',
'typo3/sysext/core/Documentation/Changelog/9.5.1/Feature-87748-AddSiteProcessor.rst',
'typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-87748-AddSiteProcessor.rst',
'typo3/sysext/core/Documentation/Changelog/master/Feature-87748-AddSiteProcessor.rst',
'typo3/sysext/core/Documentation/Changelog/9.5/Feature-87748-AddSiteProcessor.rst',
];
foreach ($filenames as $filename) {
echo preg_match('#'
. 'Changelog/' # Ignore all Changelog files
. '(' # which are either
. '.+/(Feature|Important)' # of type "Feature" and "Important" from any version
. '|' # or
. '([78]\.\d(\.[0-9x])?)' # from 7.x and 8.x (as there was no extension scanner back then)
. ')'
. '#x', $filename) . ' ' . $filename . PHP_EOL;
}
0 typo3/sysext/core/Documentation/Changelog/master/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst
1 typo3/sysext/core/Documentation/Changelog/master/Feature-58637-PurgeLanguagePacksInLanguageModule.rst
0 typo3/sysext/core/Documentation/Changelog/9.5.x/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst
1 typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-58637-PurgeLanguagePacksInLanguageModule.rst
0 typo3/sysext/core/Documentation/Changelog/9.5/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst
1 typo3/sysext/core/Documentation/Changelog/9.5/Feature-58637-PurgeLanguagePacksInLanguageModule.rst
1 typo3/sysext/core/Documentation/Changelog/8.7.x/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst
1 typo3/sysext/core/Documentation/Changelog/8.7.x/Feature-58637-PurgeLanguagePacksInLanguageModule.rst
1 typo3/sysext/core/Documentation/Changelog/8.7/Breaking-78522-RemoveBackendUserOptionDebugInWindow.rst
1 typo3/sysext/core/Documentation/Changelog/8.7/Feature-58637-PurgeLanguagePacksInLanguageModule.rst
1 typo3/sysext/core/Documentation/Changelog/9.5.1/Feature-87748-AddSiteProcessor.rst
1 typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-87748-AddSiteProcessor.rst
1 typo3/sysext/core/Documentation/Changelog/master/Feature-87748-AddSiteProcessor.rst
1 typo3/sysext/core/Documentation/Changelog/9.5/Feature-87748-AddSiteProcessor.rst
Updated by Gerrit Code Review over 5 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790
Updated by Gerrit Code Review over 5 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790
Updated by Gerrit Code Review over 5 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790
Updated by Anja Leichsenring over 5 years ago
- Related to Task #87774: Adjust rst file indizes for proper validation added
Updated by Gerrit Code Review over 5 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790
Updated by Gerrit Code Review over 5 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790
Updated by Gerrit Code Review over 5 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59790
Updated by Gerrit Code Review over 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59818
Updated by Gerrit Code Review over 5 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59819
Updated by Anonymous over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 8e64eda606d40580a3909640d5147d42f06733e6.
Updated by