Bug #87821

Form Framework has problems with Windows Line Endings

Added by Guido Schmechel 9 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2019-03-02
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:
Remote Sprint

Description

Form Framework stops the output of forms when using Windows Line Endings, e.g. due to a faulty upload. The editor gets no indication and the error is hard to find as an integrator.

To prevent this, chr (13) can be removed from the metadata:
https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php#L687

How can you test it?
Just build an simple form yaml config and change the line ending via editor (e.g. PHP Storm) from "LF" to "CRLF"

Associated revisions

Revision 8fd95447 (diff)
Added by Guido Schmechel 7 months ago

[BUGFIX] Remove Windows line breaks

In order to prevent a faulty configuration and silent output,
line breaks in the MetaData value are now also removed.

Resolves: #87821
Releases: master, 9.5
Change-Id: I243ce719474326dea24805695e27b793ba22ef6a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59833
Tested-by: Björn Jacob <>
Tested-by: TYPO3com <>
Tested-by: Ralf Zimmermann <>
Reviewed-by: Björn Jacob <>
Reviewed-by: Ralf Zimmermann <>

Revision dd9daf8e (diff)
Added by Guido Schmechel 7 months ago

[BUGFIX] Remove Windows line breaks

In order to prevent a faulty configuration and silent output,
line breaks in the MetaData value are now also removed.

Resolves: #87821
Releases: master, 9.5
Change-Id: I243ce719474326dea24805695e27b793ba22ef6a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60536
Tested-by: TYPO3com <>
Tested-by: Ralf Zimmermann <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Ralf Zimmermann <>

History

#1 Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59833

#2 Updated by Guido Schmechel 9 months ago

  • Description updated (diff)

#3 Updated by Bjoern Jacob 8 months ago

  • Sprint Focus set to Remote Sprint

#4 Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59833

#5 Updated by Gerrit Code Review 7 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60536

#6 Updated by Guido Schmechel 7 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF