Bug #87821

Form Framework has problems with Windows Line Endings

Added by Guido Schmechel about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2019-03-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:
Remote Sprint

Description

Form Framework stops the output of forms when using Windows Line Endings, e.g. due to a faulty upload. The editor gets no indication and the error is hard to find as an integrator.

To prevent this, chr (13) can be removed from the metadata:
https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php#L687

How can you test it?
Just build an simple form yaml config and change the line ending via editor (e.g. PHP Storm) from "LF" to "CRLF"

#1

Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59833

#2

Updated by Guido Schmechel about 2 years ago

  • Description updated (diff)
#3

Updated by Bjoern Jacob about 2 years ago

  • Sprint Focus set to Remote Sprint
#4

Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59833

#5

Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60536

#6

Updated by Guido Schmechel about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF