Bug #87938

Avoid superfluous cast and creation of instances DocumentTypeExclusionRestriction

Added by Manuel Selbach about 1 year ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2019-03-16
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

It turned out, that the implementation uses multiple cast to integer and multiple instances of DocumentTypeExclusionRestriction are created.


Related issues

Duplicated by TYPO3 Core - Bug #90356: options.pageTree.excludeDoktypes doesn't work with multiple items Closed 2020-02-11

Associated revisions

Revision c7289fa3 (diff)
Added by Manuel Selbach 3 months ago

[BUGFIX] Use single instance of DocumentTypeExclusionRestriction

With this change, the DocumentTypeExclusionRestrictionTest will use
NOT IN instead of <>. This will allow to have only one instance of that
restriction.

Additionally multiple casts to integer have been removed.

Resolves: #87938
Releases: master, 9.5
Change-Id: I3c1c5cc47800dae3f13afc654f55236634ad5bc5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60275
Tested-by: TYPO3com <>
Tested-by: Dennis Prinse <>
Tested-by: Richard Haeser <>
Reviewed-by: Dennis Prinse <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Claus Due <>
Reviewed-by: Richard Haeser <>

Revision 55799d7b (diff)
Added by Manuel Selbach 3 months ago

[BUGFIX] Use single instance of DocumentTypeExclusionRestriction

With this change, the DocumentTypeExclusionRestrictionTest will use
NOT IN instead of <>. This will allow to have only one instance of that
restriction.

Additionally multiple casts to integer have been removed.

Resolves: #87938
Releases: master, 9.5
Change-Id: I3c1c5cc47800dae3f13afc654f55236634ad5bc5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63292
Tested-by: TYPO3com <>
Tested-by: Richard Haeser <>
Reviewed-by: Richard Haeser <>

History

#1 Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60275

#2 Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60275

#3 Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60275

#4 Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60275

#5 Updated by Gerrit Code Review about 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60275

#6 Updated by Richard Haeser 4 months ago

This results in issue #87938

#7 Updated by Richard Haeser 4 months ago

  • Duplicated by Bug #90356: options.pageTree.excludeDoktypes doesn't work with multiple items added

#8 Updated by Gerrit Code Review 3 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60275

#9 Updated by Gerrit Code Review 3 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60275

#10 Updated by Gerrit Code Review 3 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63292

#11 Updated by Gerrit Code Review 3 months ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63292

#12 Updated by Manuel Selbach 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#13 Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF