Bug #88011

Finisher use wrong overrides

Added by Jan Delius 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Should have
Category:
Form Framework
Target version:
-
Start date:
2019-03-26
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
Remote Sprint

Description

In certain situations, the Flexform form gets incorrect overwrite values in the frontend.

If I set up a form and overwrite the finisher settings on it, this content is written into the Flexform field with a generated sheet ID.
When I now change the form it generates a second sheet and my first changes remain parallel in the database.
After the next change to the first form both overrides remain existing, in the frontend the same "<field index=...>" value is used as the later value in the flexform. This allows me to maintain the correct finisher in the backend, but in the frontend (with the same finisher type and field name) the values are taken from the second form.

To reproduce:

1. Create the form with E-Mail Finisher and activate "Override finisher settings" in the content element. For the finisher, overwrite the subject with the following value: "Subject 1".
-> Submit the form. The subject is "Subject 1".
2. As in step 1, create a form and select and overwrite it in the same content element. Here "Subject 2" is selected as the subject.
-> Submit the form. The subject is "Subject 2".
3. Select the first form again in the content element. After sending the form, the e-mail has the subject "Subject 2", although in the overrides in the backend it says "Subject 1".

This problem is checked in latest released 8.7 and latest released 9.5

Associated revisions

Revision 1b0c57c2 (diff)
Added by Ralf Zimmermann 4 months ago

[BUGFIX] Use form specific flexform sheets within the frontend

Use contextual flexform sheets to identify ext:form finisher overrides
within the frontend.

Resolves: #88011
Releases: master, 9.5
Change-Id: I0a21deed29419281478f358ff61986d65b26dd0e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60548
Tested-by: Mathias Brodala <>
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Reviewed-by: Mathias Brodala <>
Reviewed-by: Susanne Moog <>

Revision ecc0e0e6 (diff)
Added by Ralf Zimmermann 4 months ago

[BUGFIX] Use form specific flexform sheets within the frontend

Use contextual flexform sheets to identify ext:form finisher overrides
within the frontend.

Resolves: #88011
Releases: master, 9.5
Change-Id: I0a21deed29419281478f358ff61986d65b26dd0e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60604
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Reviewed-by: Susanne Moog <>

History

#1 Updated by Bjoern Jacob 5 months ago

  • Sprint Focus set to Remote Sprint

#2 Updated by Ralf Zimmermann 4 months ago

  • Status changed from New to In Progress
  • Assignee set to Ralf Zimmermann

#3 Updated by Ralf Zimmermann 4 months ago

  • TYPO3 Version changed from 8 to 9

#4 Updated by Gerrit Code Review 4 months ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60548

#5 Updated by Gerrit Code Review 4 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60548

#6 Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60548

#7 Updated by Gerrit Code Review 4 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60548

#8 Updated by Gerrit Code Review 4 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60548

#9 Updated by Gerrit Code Review 4 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60548

#10 Updated by Gerrit Code Review 4 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60548

#11 Updated by Gerrit Code Review 4 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60548

#12 Updated by Gerrit Code Review 4 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60548

#13 Updated by Gerrit Code Review 4 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60548

#14 Updated by Gerrit Code Review 4 months ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60548

#15 Updated by Gerrit Code Review 4 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60604

#16 Updated by Anonymous 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#17 Updated by Benni Mack 4 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF