Bug #88092

PageLayoutView::getLocalizedPageTitle() has wrong null coalesce usage in condition

Added by Andreas Fernandez about 2 months ago. Updated 19 days ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-04-05
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

PageLayoutView::getLocalizedPageTitle() has the condition $this->tt_contentConfig['sys_language_uid'] ?? 0 > 0 which is wrong and basically evaluates to isset($this->tt_contentConfig['sys_language_uid']) ? $this->tt_contentConfig['sys_language_uid'] || 0 > 0


Related issues

Related to TYPO3 Core - Task #84375: Use ServerRequestInterface in PageLayoutController Closed 2018-03-16

Associated revisions

Revision 5600691c (diff)
Added by Andreas Fernandez about 2 months ago

[BUGFIX] Fix null coalesce evalutation in PageLayoutView::getLocalizedPageTitle()

This commit fixes a usage of the null coalesce operator within a condition.

Resolves: #88092
Related: #84375
Releases: master, 9.5
Change-Id: Ic34fb492e66eb224d0e617405e8ae2be69a16aa4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60400
Reviewed-by: Tymoteusz Motylewski <>
Reviewed-by: Mona Muzaffar <>
Reviewed-by: André Schließer <>
Reviewed-by: Anja Leichsenring <>
Tested-by: TYPO3com <>
Tested-by: Mona Muzaffar <>
Tested-by: André Schließer <>
Tested-by: Anja Leichsenring <>

Revision 7bbbb2fc (diff)
Added by Andreas Fernandez about 2 months ago

[BUGFIX] Fix null coalesce evaluation in PageLayoutView::getLocalizedPageTitle()

This commit fixes a usage of the null coalesce operator within a condition.

Resolves: #88092
Related: #84375
Releases: master, 9.5
Change-Id: Ic34fb492e66eb224d0e617405e8ae2be69a16aa4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60406
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Andreas Fernandez about 2 months ago

  • Related to Task #84375: Use ServerRequestInterface in PageLayoutController added

#2 Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60400

#3 Updated by Gerrit Code Review about 2 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60406

#4 Updated by Gerrit Code Review about 2 months ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60406

#5 Updated by Andreas Fernandez about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack 19 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF